Repository navigation
Added support for HOTKEYS commands - #1408
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8838e20. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
New optional server-admin APIs on single-node clients only, with explicit failures on cluster/distributed and tests; no changes to data commands or auth.
Overview
Adds client support for Redis 8.6 HOTKEYS so a single-node
Redisclient can start a tracking session, read ranked hot keys by CPU and/or network bytes, stop, and reset.On standalone clients,
hotkeys_start,hotkeys_get,hotkeys_stop, andhotkeys_resetbuild the wire command (metrics, count, duration, sample, optionalslots) andHashifyHotkeysnormalizeshotkeys_getreplies across RESP2/RESP3, including[key, value]pairs for theby-*fields.Redis::ClusterandRedis::Distributedoverride all four methods to raiseNotImplementedErrorwith guidance to connect to one node directly, because tracking is server-wide and not routable. The cluster driver wrapspipelined/multiblocks withHotkeysGuardso HOTKEYS cannot slip through to an arbitrary shard.README documents usage and limitations; integration tests cover the happy path, error cases, argument encoding, pipelined
hotkeys_get, and cluster/distributed rejection.Reviewed by Cursor Bugbot for commit 8838e20. Bugbot is set up for automated code reviews on this repo. Configure here.