Repository navigation
[Sync to prerelease] chore: refresh frozen revealjs site_libs for Quarto 1.12.1 - #2347
Merged
Merged
Conversation
Rendering a project with `freeze: true` copies `_freeze/site_libs` over the freshly generated `site_libs` whenever a frozen page is thawed, so the revealjs runtime tracked in the freezer wins over the one shipped with the Quarto version doing the render (quarto-dev/quarto-cli#10391). The tracked copy predated 1.12.1: reveal.js core, the notes, quarto-support and reveal-menu plugins, and the line-highlight plugin differed from a fresh 1.12.1 render. As a result a preview rendered with 1.12.1 still shipped the old line-highlight plugin, which ignores `code-line-fragment-indices`. Regenerated by deleting `_freeze/site_libs/revealjs` and re-rendering the five frozen revealjs pages with Quarto 1.12.1 and the prerelease-docs profile. The frozen results of those pages are unchanged: re-executing them only altered random widget ids and figure bytes, so they were left as they were. (cherry picked from commit 5251a75)
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync of #2346 to
prerelease.Original PR
chore: refresh frozen revealjs site_libs for Quarto 1.12.1
The live sites serve an old reveal.js line-highlight plugin even though they are rendered with Quarto 1.12.1. quarto.org and prerelease.quarto.org both deliver a
line-highlight.jsthat is byte-identical to the copy tracked in_freeze/site_libs/revealjs, not to the one shipped in 1.12.1. It showed up in the deploy preview of #2340, where thecode-line-fragment-indicesexample ran the highlight steps in the wrong order.With
freeze: true, rendering a page that has frozen results copies_freeze/site_libsover the freshly generatedsite_libs. The revealjs runtime tracked there wins over the one from the Quarto version doing the render, see quarto-dev/quarto-cli#10391. The tracked copy predated 1.12.1: reveal.js core, the notes, quarto-support and reveal-menu plugins, and the line-highlight plugin all differed from a fresh 1.12.1 render. Both publish jobs render with the latest prerelease, andmainandprereleasecarry the same freezer tree, so one refresh covers both._freeze/site_libs/revealjswas deleted and the five frozen revealjs pages were re-rendered with 1.12.1, so the freezer regenerates it. The frozen results of those pages are unchanged: re-executing them only altered random widget ids and figure bytes.Test Plan
line-highlight.jsin_freeze/site_libs/revealjsis identical to the file in the Quarto 1.12.1 releaseline-highlight.jsprerelease,/deploy-previewon docs(revealjs): document code-line-fragment-indices #2340 shows note 1, line 1, note 2, line 2 on the example 5 slideRelated to quarto-dev/quarto-cli#10391