Repository navigation
Polish kickmix more - #1979
Open
Strilanc wants to merge 1 commit into
Open
Polish kickmix more#1979Strilanc wants to merge 1 commit into
Strilanc wants to merge 1 commit into
Conversation
- Fix various signatures not using `km.`, like `b` instead of `km.b` - Add some missing examples - Add support for broadcasting z operations - Fix some typos in the file format documentation - Fix some other inconsistencies
| broadcast_z_leaf(self, t.cast_data<bool>()); | ||
| break; | ||
| case QXZTypeTag8::MAY_BE_MIXED: | ||
| case QXZTypeTag8::MAY_BE_MIXED_BUT_IS_ALL_ZLIKE: { |
Collaborator
There was a problem hiding this comment.
Do we also need a MAY_BE_MIXED_BUT_IS_ALL_XLIKE to support builder.z(km.array([km.q(0), km.xb(1)])[:1])?
tanujkhattar
approved these changes
Oct 16, 2026
tanujkhattar
left a comment
tanujkhattar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM % one comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
km., likebinstead ofkm.b