Repository navigation
Replace Xoshiro with ChaCha in kickmix simulator - #1978
Merged
Merged
Conversation
tanujkhattar
changed the title
Strilanc
approved these changes
Oct 16, 2026
Strilanc
left a comment
Strilanc
left a comment
Contributor
There was a problem hiding this comment.
LGTM % add references for where the test vectors come from
| } | ||
| rng.buffer_idx = 16; | ||
|
|
||
| const uint32_t expected_block[16] = { |
Contributor
There was a problem hiding this comment.
Add a comment linking to https://www.rfc-editor.org/info/rfc8439/#section-2.3.2
| rng.buffer_idx = 16; | ||
|
|
||
| const uint32_t expected_block[16] = { | ||
| 0xfb9dadee, |
Contributor
There was a problem hiding this comment.
Where do these come from?
|
|
||
| namespace { | ||
| constexpr uint32_t RFC8439_INIT_WORDS[16] = { | ||
| 0x61707865, |
Contributor
There was a problem hiding this comment.
Add a comment linking to https://www.rfc-editor.org/info/rfc8439/#section-2.3.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a CSPRNG in kickmix simulator.