Repository navigation
Fix unwanted phase in QROAMClean - #1977
Open
rupasri118 wants to merge 2 commits into
Open
rupasri118 wants to merge 2 commits into
rupasri118 wants to merge 2 commits into
Conversation
rupasri118
force-pushed
the
fix-qroamclean-sign
branch
from
October 16, 2026 06:31
0a0975b to
098f1d5
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1968.
QROAMCleanused approximate CSwap gates in its swap network, which can introduce unwanted relative phases. This caused the output state to have a negative amplitude for an address that should have a positive amplitude.This change uses exact CSwap gates in
QROAMCleanto prevent unwanted phases while preserving approximate CSwap as the default behavior forSwapWithZero.Changes
CSwapgates inQROAMClean.CSwapas the default forSwapWithZero.Testing
qroam_clean_test.py— 26 passed, 1 skipped, 1 xfailed.qroam_clean_test.py,swap_with_zero_test.py, andcswap_approx_test.py— 79 passed, 6 skipped, 3 xfailed.