Skip to content

fix(facts.files): add return type to FileContents - #2065

Open
kelno wants to merge 1 commit into
pyinfra-dev:3.xfrom
kelno:facts-filecontents-type
Open

kelno wants to merge 1 commit into
pyinfra-dev:3.xfrom
kelno:facts-filecontents-type

Conversation

@kelno

@kelno kelno commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Lets type checkers know what host.get_fact(FileContents, ...) returns, instead of an unknown type. No behaviour change.

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (FileContents fact tests only; full suite left to CI)
  • Type checking & code style passes (see scripts/dev-lint.sh)
  • Pull request title follows the
    conventional commits format

Update process method to specify return type as list[str] or None.
@wowi42 wowi42 added bug Label for all kind of bugs. facts Issues with facts. operations Issues with operations. labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Label for all kind of bugs. facts Issues with facts. operations Issues with operations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants