[mvanhorn]

Background

An operation gated on a bare fact class always runs, even when the fact would be falsey. The condition is silently accepted without collecting the fact.

Fact classes pass callable validation, but invoking them constructs a truthy instance instead of retrieving a fact value. _if therefore evaluates the instance rather than the fact.

Summary of the fix

Adds any_fact and all_fact to combine zero-argument facts with explicit OR and AND semantics. Their conditions retrieve facts lazily from the current executing host and short-circuit. Bare FactBase and ShortFactBase subclasses are rejected during preparation before operation registration, including conditions inherited from deploy or host arguments. Documentation explains the helpers, empty-condition behavior, and lambdas for facts requiring arguments.

Verification

The targeted tests (tests/test_api/test_api_operations.py, tests/test_operations_utils.py) pass, 111 tests, and the full pytest suite passes (2252 passed). ruff check, ruff format --check, mypy and scripts/lint_arguments_sync.py all pass.

• Pull request is based on the default branch (3.x at this time)
• Pull request includes tests for any new/updated operations/facts
• Pull request includes documentation for any new/updated operations/facts
• Tests pass (see scripts/dev-test.sh)
• Type checking & code style passes (see scripts/dev-lint.sh)
• Pull request title follows the conventional commits format

Fixes #2041

AI disclosure:

AI was used for assistance.

• Tools: Codex.