Skip to content

Test with view_component 3 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thatbudakguy merged 1 commit into from
Mar 26, 2026
Merged

Test with view_component 3 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ jobs:
ruby: ["3.3"]
rails_version: ["7.1.5.1", "7.2.2.1", "8.0.1"]
blacklight_version: ["~> 8.0"]
view_component_version: ["~> 3.0"]
additional_engine_cart_rails_options: ["--css bootstrap"]
additional_name: [""]
legacy_config: [""]
Expand All @@ -33,6 +34,7 @@ jobs:
BLACKLIGHT_VERSION: ${{ matrix.blacklight_version }}
CI_TEST_LEGACY_CONFIGURATION: ${{ matrix.legacy_config }}
ENGINE_CART_RAILS_OPTIONS: "--skip-git --skip-listen --skip-spring --skip-keeps --skip-action-cable --skip-coffee --skip-test ${{ matrix.additional_engine_cart_rails_options }}"
VIEW_COMPONENT_VERSION: ${{ matrix.view_component_version }}
steps:
- uses: actions/checkout@v2
- name: Set up Ruby ${{ matrix.ruby }}
Expand Down
42 changes: 21 additions & 21 deletions blacklight-oembed.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,34 @@
# coding: utf-8
lib = File.expand_path('../lib', __FILE__)
lib = File.expand_path('lib', __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'blacklight/oembed/version'

Gem::Specification.new do |spec|
spec.name = "blacklight-oembed"
spec.name = 'blacklight-oembed'
spec.version = Blacklight::Oembed::VERSION
spec.authors = ["Chris Beer"]
spec.email = ["cabeer@stanford.edu"]
spec.summary = %q{Oembed display for Blacklight}
spec.homepage = "https://github.com/sul-dlss/blacklight-oembed"
spec.license = "Apache 2.0"
spec.authors = ['Chris Beer']
spec.email = ['cabeer@stanford.edu']
spec.summary = 'Oembed display for Blacklight'
spec.homepage = 'https://github.com/sul-dlss/blacklight-oembed'
spec.license = 'Apache 2.0'

spec.files = `git ls-files`.split($/)
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]
spec.require_paths = ['lib']

spec.add_dependency "rails"
spec.add_dependency 'blacklight', '>= 7.25', '< 9'
spec.add_dependency "ruby-oembed"
spec.add_dependency 'rails'
spec.add_dependency 'ruby-oembed'
spec.add_dependency 'view_component', '~> 3.0'

spec.add_development_dependency "bundler", ">= 1.5"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec-rails", "~> 6"
spec.add_development_dependency "rspec-its"
spec.add_development_dependency "rspec-activemodel-mocks"
spec.add_development_dependency "rspec-collection_matchers"
spec.add_development_dependency "solr_wrapper"
spec.add_development_dependency "engine_cart", "~> 2.0"
spec.add_development_dependency "capybara"
spec.add_development_dependency "poltergeist", ">= 1.5.0"
spec.add_development_dependency 'bundler', '>= 1.5'
spec.add_development_dependency 'capybara'
spec.add_development_dependency 'engine_cart', '~> 2.0'
spec.add_development_dependency 'poltergeist', '>= 1.5.0'
spec.add_development_dependency 'rake'
spec.add_development_dependency 'rspec-activemodel-mocks'
spec.add_development_dependency 'rspec-collection_matchers'
spec.add_development_dependency 'rspec-its'
spec.add_development_dependency 'rspec-rails', '~> 6'
spec.add_development_dependency 'solr_wrapper'
end
4 changes: 4 additions & 0 deletions spec/test_app_templates/Gemfile.extra
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,7 @@ if ENV['BLACKLIGHT_VERSION'] == 'github'
elsif ENV['BLACKLIGHT_VERSION'] && !ENV['BLACKLIGHT_VERSION'].empty?
gem 'blacklight', ENV['BLACKLIGHT_VERSION']
end

unless ENV['VIEW_COMPONENT_VERSION'].to_s == ""
gem 'view_component', ENV.fetch('VIEW_COMPONENT_VERSION')
end
Loading