Repository navigation
Conversation
|
There was a problem hiding this comment.
🟡 Changes recommended
Repository-incompatible formatting blocks CI before type checking and unit tests, and the new hover selector incorrectly underlines disabled buttons.
2 open issues
What changed in this PR
This draft uses Button changes to exercise fork CI behavior related to #1525. It is explicitly marked DO NOT MERGE and does not modify workflows.
Changes:
- Reformats the Button implementation and stylesheet.
- Changes Button hover styling from no text decoration to an underline.
- Removes the
leadingVisualprop’s documentation comment without changing its API.
| File | Description |
|---|---|
packages/react/src/Button/Button.tsx |
Reformats code and removes one prop documentation comment; runtime logic is unchanged. |
packages/react/src/Button/Button.module.css |
Adds hover underlining and reformats CSS. |
Review effort: Balanced
| import { clsx } from "clsx"; | ||
| import React, { forwardRef, useCallback, type Ref, ReactElement } from "react"; | ||
| import type { Icon } from "@primer/octicons-react"; |
|
|
||
| .Button:hover { | ||
| text-decoration: none; | ||
| text-decoration: underline; |
Summary
Related to #1525
Testing how forks behave. DO NOT MERGE.