Skip to content

fix(wab): return 401 instead of 500 for logged-out personal API token calls #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jameswillis99 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(wab): return 401 instead of 500 for logged-out personal API token calls #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions platform/wab/src/wab/server/db/DbMgr.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
User,
} from "@/wab/server/entities/Entities";
import { createTeam as createTeamRoute } from "@/wab/server/routes/teams";
import { UnauthorizedError } from "@/wab/shared/ApiErrors/errors";
import {
CmsMetaType,
CmsTableId,
Expand Down Expand Up @@ -1993,6 +1994,20 @@ describe("DbMgr.user", () => {
);
});
});

it("rejects personal API token calls from anonymous users", () =>
withDb(async (_sudo, _users, [userMgr], _project, entMgr) => {
const anonMgr = new DbMgr(entMgr, ANON_USER);
await expect(anonMgr.listPersonalApiTokens()).rejects.toBeInstanceOf(
UnauthorizedError,
);
await expect(anonMgr.createPersonalApiToken()).rejects.toBeInstanceOf(
UnauthorizedError,
);

await userMgr().createPersonalApiToken();
expect(await userMgr().listPersonalApiTokens()).toHaveLength(1);
}));
});

describe("DbMgr organization entitlements", () => {
Expand Down
5 changes: 4 additions & 1 deletion platform/wab/src/wab/server/db/DbMgr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6526,7 +6526,10 @@ export class DbMgr implements MigrationDbMgr {
if (this.actor.type === "SuperUser" && !userId) {
throw new Error("Super user must specify userId to use");
}
return ensure(userId, "User id should exist");
if (!userId) {
throw new UnauthorizedError("Must be logged in");
}
return userId;
}

isUserIdSelf(userId?: string) {
Expand Down
Loading