Skip to content

fix(mobile): the iPhone new-chat button sits beside the tab bar on iOS 26.6 #24492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Oct 25, 2026
+7 −6
Merged

fix(mobile): the iPhone new-chat button sits beside the tab bar on iOS 26.6 #24492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions apps/mobile/modules/t3-native-controls/ios/T3SidebarTabBarView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ private final class WorkspaceTabBar: UITabBar {

override func layoutSubviews() {
super.layoutSubviews()
let row = tabButtons(in: self).reduce(CGRect.null) { $0.union(convert($1.bounds, from: $1)) }
// iOS 26.6 doesn't copy item identifiers onto its tab buttons; the bar holds no other controls.
let identified = tabButtons(in: self) { $0.accessibilityIdentifier?.hasPrefix("workspace-tab-") == true }
let buttons = identified.isEmpty ? tabButtons(in: self) { _ in true } : identified
let row = buttons.reduce(CGRect.null) { $0.union(convert($1.bounds, from: $1)) }
if !row.isNull { onContentLayout?(row) }
}

Expand All @@ -15,12 +18,10 @@ private final class WorkspaceTabBar: UITabBar {
invalidateIntrinsicContentSize()
}

private func tabButtons(in view: UIView) -> [UIView] {
private func tabButtons(in view: UIView, matching match: (UIView) -> Bool) -> [UIView] {
view.subviews.filter { !$0.isHidden }.flatMap { subview in
if subview is UIControl, subview.accessibilityIdentifier?.hasPrefix("workspace-tab-") == true {
return [subview]
}
return tabButtons(in: subview)
if subview is UIControl, match(subview) { return [subview] }
return tabButtons(in: subview, matching: match)
}
}
}
Expand Down
Loading