Repository navigation
fix(mobile): restore Android chat content corners - #23989
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused Android UI regression fix that restores rounded thread-content corners while preserving header behavior and leaving iOS unchanged. The two-file change is localized and introduces no new capability, schema, or sensitive behavior. You can add or adjust custom eligibility rules. Learn more. |
|
Warning Review limit reachedOnly developers with an assigned seat can use this organization's usage-based review budget, and seats here are assigned manually. Ask an admin to assign a seat, or change the review continuation mode in Billing. Next included review available in 21 minutes. View limit details
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
|
Note Written by thanks @PixPMusic. separating the header from the clipped content fixes the boundary without replacing the shared screen host or composer. current main still contains that regression. i merged verification:
unverified: current-head native android clipping, keyboard behavior, and ios runtime. this vm has no attached android device, and t3 device access is disabled. chrome cannot verify native layout. before merging, confirm rounded content below the header in chat and no-model drafts, and that draft-to-live navigation keeps the composer and keyboard. coderabbit skipped this head because its review-seat limit was reached; its prior review had no findings. |
Problem
Android chat and new-thread panels have square top corners below the header. The screen-host refactor in #23467 moved the header inside the rounded container, so clipping happens above the header instead of around the content.
Change
Place the Android rounded content pane below the header while retaining the shared screen host. Let fallback screens supply their header separately, including the draft shown when no model is selected. The iOS header/body order and background remain the same.
Scope and approval
Small, focused fix for an obvious visual regression: restore the existing 28 dp Android content corners. Based directly on main at
807319c276c6831b2c219640e9da5b38019a8f1d, independent of the toast changes in #23968.Verification
vp run check:changed: format, lint, knip, and affected typechecks pass.Unfolded chat · Folded draft · Unfolded draft
Model: GPT-6.1 Sol | Harness: Codex in T3 Code