Repository navigation
Conversation
The periodic chain-identity re-check shut lnd down the first time the node failed to answer, even when the node was only restarting: a bitcoind restart that lands on the 5-minute tick answers -28 (RPC warm-up) or refuses the connection, and that was reported as "the connected Bitcoin node is not on the Bitcoin BLAKE2b chain". The re-check now tells a node that cannot answer (warm-up, connection refused or dropped) from one that answers with another chain. The first is asked again every 15 seconds for up to 5 minutes before it counts as a mismatch; the second is still reported at once. The start-up check is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The periodic chain-identity re-check shuts lnd down the first time the node fails to answer, even when the node is only restarting.
On our node the bitcoind is restarted after a block when the AirVPN exit IP changes (so it announces the new
externalip). Today the restart landed on the 5-minute tick and lnd stopped with:The node was back two seconds later; Docker restarted lnd, but every channel reconnected for nothing.
This tells a node that cannot answer (
-28RPC warm-up, connection refused/reset, EOF, othernet.Error) from one that answers with another chain. The first is asked again every 15 s for up to 5 min before it counts as a mismatch; the second (wrong header, height out of range, any other RPC error) is still reported at once. The start-up check is unchanged.Test:
go test -race -run 'ChainIdentity|NodeUnreachable' ./chainreg/