Repository navigation
Grant signing accepts the Delegated SD-JWT layout and the newer key-binding type (#473) #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8735216
Grant signing accepts the Delegated SD-JWT layout and the newer key-b…
eb44535
Test the Delegated layout's "nothing behind the gap" refusal for real…
92858dd
Replay a real Multipaz Wallet answer as a test: its sd_hash matches t…
65383a4
Spend a grant signed in the Delegated layout, and verify it at the me…
c282dec
Changelog: say merchants on 0.6.0 refuse these permissions, and what …
379a8ca
Refuse a key binding that is not three parts at signing (review of #474)
590edbf
Comments, messages and the draft citation say what the code does (rev…
32dec42
Name the simulator option like its siblings, and throw when it would …
435159c
Test that a hop naming no further key must be typed terminal (review …
0e6da94
Pin the key binding's character set, say the wallet is a development …
32684c8
Pin `+` and `/` in the key binding's check, and correct its comment (…
ded3e14
Accept both spellings of the terminal key-binding type, like AP2's ve…
aba1d9b
The signing page does not accept the terminal `kb-sd-jwt`; the change…
9b0cf05
Say why the signing page still lets `kb+sd-jwt` through, and pin it (…
0d8f23f
Header and changelog say what the code does about the older terminal …
fa38964
Clearer wallet-type refusal, one list of wallet types, and a real-ans…
6cf8170
Changelog: say the page now accepts what it used to refuse, and tell …
2879b2e
Decode the key binding strictly again, and tighten the replay test an…
94e09ca
Changelog: custom backends get the wallet's raw answer, and may refus…
c7684d6
Test the earlier layout's strict key-binding read, and say only 0.6.0…
b585718
One split, one stored string: drop `normalized`, split the guard, rea…
6d03ab3
Docs: name the backend type in the README, shorten the backend note, …
5758051
Say the page now also refuses a padded or respelled signature, say "b…
d7b245b
Changelog: what 0.6.0 did with a signature outside base64url, for eac…
dzuluaga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.