Repository navigation
Docs: sign a spending grant with the official Multipaz Payment card; the minted card is a test fixture - #470
Conversation
Claude reviewVerdict: ⛔ Needs changes This docs-only change tells developers to sign a spending grant on their phone with the official Multipaz Payment card instead of a card they mint themselves. Nothing runs differently, and it never claims the card's issuer is checked. Two sentences in the gate's README are wrong, though, and should be fixed first. Fix before merging
Worth a look
Details for the author
Backed by the code: the vct pair Coverage: scope |
…warn about the mdoc card (review of #470) Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: ⛔ Needs changes Since the last review: 1 fixed, 1 still open. This docs-only change tells developers how to sign a spending grant on their phone with the official Multipaz Payment card. The new commit now explains correctly why the wallet shows the store as unknown. One older contradiction is still there. Fix before merging
Worth a look
Details for the authorScope: Fixed: the earlier finding at Still open:
Backed by the evidence: multipaz pull request 2196 exists, is open, and builds on 2178, where the shared spending-permission renderer for the wallet's pull request 48 lives. The new Coverage: read commit 631054e in full, along with |
…), step 3 for phone and computer, mdoc citation (review of #470) Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: 💬 Ready — small notes Since the last review: 2 fixed, 0 still open. This docs-only change tells developers how to sign a spending grant on their phone with the official Multipaz Payment card. The new commit removes the last contradiction: the older passages now say only that the gate doesn't check who issued the card. It is safe to merge. Worth a look (not blocking)
Details for the authorScope: Fixed:
Still noted (not in this diff): No code changed, so no bypass test is needed. The commit is DCO-signed. Coverage: read commit 427f19e in full, along with |
There was a problem hiding this comment.
Thanks for the video, Ever! It's great to see the official Payment card signing a grant end to end.
⛔ Needs changes. Two small fixes. The docs now send developers to the official SD-JWT Payment card, and the #466 recording shows a grant ending authorized with it.
Before merge
- Merging will close #413. The body says "Does not close #413"; GitHub reads "close #413" as a closing keyword, and the PR now lists #413 as an issue it closes. #413 asks for changes to
intent-sign/page.tsand the README's "Delegated purchases" line, which this PR doesn't make. Reword to "Leaves #413 open". - Step 1 can't be followed as written. "Build the wallet from that branch" leaves out the hard part: it needs openwallet-foundation/multipaz#2196 published to mavenLocal first. For now, link an APK of the build you recorded, and say it's a development build of unmerged pull requests. Replacing it with the apps.multipaz.org release is tracked in #472. Also: your #466 build was
…-dirty(uncommitted changes). If any of those were needed for signing, put them in openwallet-foundation/multipaz-wallet#48 so the APK matches a branch.
Worth a look
- One line in the body: the wallet requirement isn't new (
mainalready needed a patched build); this PR changes only the card and names the build. intent-sign/page.ts:136still says "patched" build. Outside this diff.
Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: 💬 Ready — small notes Since the last review: 0 open from Claude. Both items the maintainer asked for are done. This docs-only change explains how to sign a spending grant on a phone with the official Multipaz Payment card. The new commit makes step 1 possible to follow: it links a download of the exact wallet build used in the recorded run, and the branch it was built from. It is safe to merge. Worth a look (not blocking)
Details for the authorScope: Maintainer's requests: (1) The "close #413" wording is gone. The body now says "Leaves #413 open", and Worth a look:
Still noted (not in this diff): the UI copy in No code changed, so no bypass test is needed. Honesty fencing is intact: grants stay Coverage: read commit c8d8006 in full, plus |
…self-review of #470) Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: 💬 Ready — small notes Since the last review: 1 fixed, 1 still open (not blocking). This docs-only change explains how to sign a spending grant on a phone with the official Multipaz Payment card. The new commit adds a checksum for the wallet download, a fingerprint readers can compare before installing. I downloaded the file, and its checksum matches the one in the docs. It is safe to merge. Worth a look (not blocking)
Details for the authorScope: Fixed (earlier worth-a-look): the APK had no integrity pin. Still open (not blocking):
No code changed, so no bypass test is needed. Honesty fencing is intact: grants stay Coverage: read commit d51e971 in full and the README line it changed. Downloaded the APK and checked its hash. Read the PR body and the issue #466 comments for the build version. Dimensions: docs truthfulness, honesty fencing and PR text, the only ones a 3-line docs delta can affect. No sub-agents. Effort: |
Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: 💬 Ready — small notes Since the last review: 1 fixed, 2 still open (not blocking). This docs-only change explains how to sign a spending grant on a phone with the official Multipaz Payment card. The new commit adds the version number the wallet download reports, so readers can confirm they installed the recorded build. That number matches the one in the recorded phone run. It is safe to merge. Worth a look (not blocking)
Details for the authorScope: Fixed (earlier worth-a-look, half of it): Still open (not blocking):
No code changed, so no bypass test is needed. Honesty fencing is intact: the README still says grants are Coverage: read commit ad4cc8b in full (a 2-line README change). Read the PR body and comments and the issue #466 comments for the recorded version. Dimensions: docs truthfulness, honesty fencing and PR text, the only ones this delta can affect. No sub-agents. Effort: |
…#470) Signed-off-by: Ever Morales <ever.morales@koombea.com>
Claude reviewVerdict: 💬 Ready — small notes Since the last review: 1 fixed, 1 still open (not blocking). This docs-only change explains how to sign a spending grant on a phone with the official Multipaz Payment card. The new commit names the command that checks the wallet download's fingerprint (its SHA-256 checksum) on Mac, Linux and Windows. All three commands are correct. It is safe to merge. Worth a look (not blocking)
Details for the authorScope: Fixed (earlier worth-a-look): Still open (not blocking):
No code changed, so no bypass test is needed. Honesty fencing is intact: grants stay Coverage: read commit a15c933 in full (a 1-line README change) and |
|
Both fixed.
About the |
|
A few optional follow-ups, none blocking this merge:
|
Video: the phone run these docs describe, a grant signed with the official Multipaz Payment card: https://youtu.be/D5lfELSPDgA
Story: Sam builds an AI shopping agent and wants it to buy sneakers while Sam is away. Sam reads the gate README to try signing a spending limit on a phone. Before, it said to mint a custom card with a script, import a file by hand and use a patched wallet. Now it says: install the wallet build, add the Payment card from the official Multipaz issuer, approve.
The only steps a developer follows now (gate README, "Device-signed grants"):
issuer.multipaz.org(SD-JWT is the credential format AP2's spending permission, calleddelegate, is defined for).Before and after
❌ Before —
main(gate README, "Device-signed grants"): "Signing on a real phone needs a wallet that supports AP2'sdelegaterequest, and no released wallet does yet … With a patched wallet build … mint one withnode tools/demo-pki/mint/mint-dpc-sdjwt.mjs --mpzpass."✅ After — this change (same section): "Sign a grant on your phone, in three steps: 1. Install a Multipaz Wallet development build … 2. In the wallet, add the Payment card from the official issuer … 3. Open the approve link and press "Sign with your wallet". On a computer, scan the QR code with the phone. Then approve in the wallet." It also names the two same-name cards on the issuer (only the SD-JWT one works) and calls the minted card a test fixture. No code changes.
Which ticket
Fixes #467, part of the epic "Approve a spending grant with the official Multipaz Wallet and its Payment card, with no custom card" (#464). Leaves #413 open (the "no released wallet can sign yet" caveat): the docs now say the same thing, and it stays open until a release can sign.
In plain terms
The docs now tell developers to try phone signing with the card the official Multipaz issuer hands out, not a card they mint themselves. The custom card stays, labelled as a test fixture.
The wallet requirement is not new:
mainalready needed a patched wallet build. This change only swaps the card and names the build.What you're approving
Text only, in five files. Worst case: a sentence is wrong or out of date. Nothing runs differently. The docs do not claim the card's issuer is verified: a grant stays
device-signed, notissuer-verified, and they say the wallet shows the requester as unknown.How to test
Read the section "Sign a grant on your phone, in three steps" in
packages/credentagent-gate/README.md, then follow it on an Android phone with a wallet development build: the grant should endauthorized(issue 466 has the recording and the build).For reviewers — the detail
packages/credentagent-gate/README.md: the "Device-signed grants" paragraph about patched wallets is replaced by the three steps, what the phone run showed, and a note that the test card has not been tried on a phone with the current request.docs/guides/testing-on-device.md: a notice at the top sends grant signing to those steps; the.mpzpassimport stays for age, loyalty and checkout.tools/demo-pki/mint/README.md:mint-dpc-sdjwt.mjsis labelled a test fixture; the "Unverified" paragraph now says the card has not been matched against the current grant request.examples/quickstart/server.mjsandREADME.md: the comment and paragraph name the official card and the wallet build.npm run buildandnpm test(1744 tests).🤖 Generated with Claude Code