Skip to content

Docs send developers to a custom payment card instead of the official Multipaz one #467

Closed

Description

@dzuluaga

In plain terms

The docs tell a developer who wants to try phone signing to mint a payment card with a script, import the file into the wallet by hand, and run a patched wallet. Once the official Multipaz Payment card works, the docs should say three things instead: install the wallet, add the card from the official issuer, approve.

Part of #464 (approve a spending grant with the official Multipaz Wallet and its Payment card). Do this after the phone run in the sibling issue passes, so the docs describe something that was seen working.

Reproduce via

The UI (reading the docs).

Steps to reproduce

Read, on main:

  1. tools/demo-pki/mint/README.md, "The SD-JWT payment credential".
  2. docs/guides/testing-on-device.md.
  3. packages/credentagent-gate/README.md, "Device-signed grants".
  4. The comment above grants: in examples/quickstart/server.mjs.

What happens

Each sends the reader to a custom card (mint-dpc-sdjwt.mjs --mpzpass) or says no released wallet can sign. None mentions the Payment card the official issuer at https://issuer.multipaz.org offers.

What should happen instead

One short "sign a grant on your phone" path: install the wallet, add the Payment card from the official issuer, approve. The custom card is described as a test fixture for this repo's own tests, not as the way to try the product.

Version or commit

main at ea12b21.


Acceptance criteria

  • AC1 docs/guides/testing-on-device.md and the gate README give the official path in three steps or fewer.
  • AC2 They say which wallet build is needed, truthfully: a build from Multipaz pull request 2178 until a release includes it, then the release.
  • AC3 The caveat issue Show the "no released wallet can sign yet" caveat where people meet phone signing #413 asks for (no released wallet can sign yet) matches the same statement, or is closed when a release can.
  • AC4 tools/demo-pki/mint/README.md labels mint-dpc-sdjwt.mjs as a test fixture.
  • AC5 No doc claims the card's issuer is verified. The trust wording stays what the page reports.

Activity

  1. added
    documentationImprovements or additions to documentation
    dxDeveloper experience
    on Nov 12, 2026
  2. self-assigned this
    on Nov 13, 2026
  3. moved this from Backlog to In progress in CredentAgenton Nov 13, 2026
  4. dzuluaga commented on Nov 17, 2026

    @dzuluaga
    ContributorAuthor

    Two things to cover here, from reviewing #468.

    1. Open with what this is for, in one plain sentence.

    I read #468's changelog entry, the cardShape description and the snippet from examples/device-signed-grants.mjs as a new developer would, with no other context. My answers were:

    • What is it for? "Post a signature to the CredentAgent endpoint." The real purpose, that the grant signing page now accepts the Payment card from Multipaz's issuer, did not come through.
    • Where does it go? "When I press the button to approve?" It doesn't go in an app at all.

    So the docs for this path should say, before any detail:

    • what it is for: approve a spending grant with the Multipaz Wallet and the Payment card from issuer.multipaz.org;
    • that a store writes nothing new: credentagent.grants.serve(app) already serves the signing page;
    • that devSimulateWalletSignature is for tests only, standing in for the phone, and is never called from an app.

    2. One more place to update.

    examples/quickstart/README.md (the "Spending grants need a wallet no store ships yet" paragraph) still says phone approval only completes with a wallet holding a demo DPC credential minted from this repo. After #468 the Multipaz card works too. That file is not in the four places listed above.

  5. moved this from In progress to In review in CredentAgenton Nov 18, 2026
  6. moved this from In review to Done in CredentAgenton Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationdxDeveloper experience

Type

No type

Fields

Priority

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions