You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Docs send developers to a custom payment card instead of the official Multipaz one #467
The docs tell a developer who wants to try phone signing to mint a payment card with a script, import the file into the wallet by hand, and run a patched wallet. Once the official Multipaz Payment card works, the docs should say three things instead: install the wallet, add the card from the official issuer, approve.
Part of #464 (approve a spending grant with the official Multipaz Wallet and its Payment card). Do this after the phone run in the sibling issue passes, so the docs describe something that was seen working.
Reproduce via
The UI (reading the docs).
Steps to reproduce
Read, on main:
tools/demo-pki/mint/README.md, "The SD-JWT payment credential".
The comment above grants: in examples/quickstart/server.mjs.
What happens
Each sends the reader to a custom card (mint-dpc-sdjwt.mjs --mpzpass) or says no released wallet can sign. None mentions the Payment card the official issuer at https://issuer.multipaz.org offers.
What should happen instead
One short "sign a grant on your phone" path: install the wallet, add the Payment card from the official issuer, approve. The custom card is described as a test fixture for this repo's own tests, not as the way to try the product.
1. Open with what this is for, in one plain sentence.
I read #468's changelog entry, the cardShape description and the snippet from examples/device-signed-grants.mjs as a new developer would, with no other context. My answers were:
What is it for? "Post a signature to the CredentAgent endpoint." The real purpose, that the grant signing page now accepts the Payment card from Multipaz's issuer, did not come through.
Where does it go? "When I press the button to approve?" It doesn't go in an app at all.
So the docs for this path should say, before any detail:
what it is for: approve a spending grant with the Multipaz Wallet and the Payment card from issuer.multipaz.org;
that a store writes nothing new: credentagent.grants.serve(app) already serves the signing page;
that devSimulateWalletSignature is for tests only, standing in for the phone, and is never called from an app.
2. One more place to update.
examples/quickstart/README.md (the "Spending grants need a wallet no store ships yet" paragraph) still says phone approval only completes with a wallet holding a demo DPC credential minted from this repo. After #468 the Multipaz card works too. That file is not in the four places listed above.
Activity
dzuluaga commentedon Nov 17, 2026
Two things to cover here, from reviewing #468.
1. Open with what this is for, in one plain sentence.
I read #468's changelog entry, the
cardShapedescription and the snippet fromexamples/device-signed-grants.mjsas a new developer would, with no other context. My answers were:So the docs for this path should say, before any detail:
issuer.multipaz.org;credentagent.grants.serve(app)already serves the signing page;devSimulateWalletSignatureis for tests only, standing in for the phone, and is never called from an app.2. One more place to update.
examples/quickstart/README.md(the "Spending grants need a wallet no store ships yet" paragraph) still says phone approval only completes with a wallet holding a demo DPC credential minted from this repo. After #468 the Multipaz card works too. That file is not in the four places listed above.Docs: cite the wallet pull request, say what the phone run showed, an…
Docs: sign a spending grant with the official Multipaz Payment card; …