Repository navigation
Write /etc/.combustion-result.json on completion - #47
Merged
Vogtinator merged 1 commit intoOct 15, 2026
Merged
Conversation
Contributor
Author
|
PTAL @Vogtinator |
laenion
approved these changes
Oct 15, 2026
laenion
left a comment
laenion
left a comment
Contributor
There was a problem hiding this comment.
Makes sense. Maybe writing some actual contents into the file would be useful given that the file is called result, but I also can't think of anything which isn't available elsewhere (timestamp of file, log in journal).
Vogtinator
approved these changes
Oct 15, 2026
When running with --complete, write a result marker file at /sysroot/etc/.combustion-result.json (consistent with ignition's /etc/.ignition-result.json). This allows jeos-firstboot to detect that combustion already configured the system and skip the firstboot wizard when ConditionFirstBoot=|yes is used as a trigger. See: openSUSE/jeos-firstboot#136 Signed-off-by: Anuj Agrawal <anujagrawal380@gmail.com>
Vogtinator
force-pushed
the
fix/combustion-result-json
branch
from
October 15, 2026 11:58
d157055 to
e9c69e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/etc/.combustion-result.jsonwhen running with--complete, consistent with ignition's/etc/.ignition-result.jsonpatternjeos-firstbootto detect that combustion already configured the system and skip the firstboot wizard whenConditionFirstBoot=|yesis used as an alternative triggerContext
When
jeos-firstbootaddsConditionFirstBoot=|yessupport (openSUSE/jeos-firstboot#98, openSUSE/jeos-firstboot#136), deleting/var/lib/YaST2/reconfig_systemalone is no longer sufficient to suppress the firstboot wizard, sinceConditionFirstBootwill still be true on first boot (machine-id is uninitialized).The marker file approach was suggested in openSUSE/jeos-firstboot#136.
Fixes #46