Skip to content

readded windows readme_cpp check in actions #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
orzel320 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

readded windows readme_cpp check in actions #567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56445a3
readded windows readme_cpp check in actions
orzel320 Oct 19, 2026
6b9986e
Attempted updating msys2 version for building wheels
orzel320 Oct 23, 2026
5751cd3
Checking if adding an upper constraint to nanobind version on windows…
orzel320 Oct 24, 2026
1b2b034
added a missing comma in pyproject.toml
orzel320 Oct 24, 2026
d556843
attempt to run windows actions with nanobind 2.15.0
orzel320 Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions .github/workflows/buildwheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,13 +53,18 @@ jobs:
- if: matrix.os == 'windows-latest'
uses: msys2/setup-msys2@v2
with:
msystem: MINGW64
msystem: UCRT64
update: false
install: >-
mingw-w64-x86_64-gcc-fortran
mingw-w64-x86_64-ninja
mingw-w64-ucrt-x86_64-gcc-fortran
mingw-w64-ucrt-x86_64-ninja
m4

- if: matrix.os == 'windows-latest'
shell: msys2 {0}
run: |
echo "$(cygpath -m /ucrt64/bin)" >> $GITHUB_PATH
echo "$(cygpath -m /usr/bin)" >> $GITHUB_PATH

- uses: actions/setup-python@v6
with:
python-version: "3.11"
Expand All @@ -72,7 +77,7 @@ jobs:
# skip 32-bit, musllinux, and free-threaded builds
CIBW_SKIP: "*-win32 *-manylinux_i686 *musllinux* cp3??t-* cp314-macosx_x86_64 cp315-macosx_x86_64"
CIBW_BEFORE_BUILD_WINDOWS: pip install delvewheel
CIBW_ENVIRONMENT_WINDOWS: CMAKE_ARGS="-DCMAKE_MAKE_PROGRAM=D:/a/_temp/msys64/mingw64/bin/ninja.exe" CMAKE_PROGRAM_PATH="D:/a/_temp/msys64/usr/bin" CMAKE_GENERATOR="Ninja" TEMP="D:/a/_temp/"
CIBW_ENVIRONMENT_WINDOWS: CMAKE_ARGS="-DCMAKE_MAKE_PROGRAM=D:/a/_temp/msys64/ucrt64/bin/ninja.exe" CMAKE_PROGRAM_PATH="D:/a/_temp/msys64/usr/bin" CMAKE_GENERATOR="Ninja" TEMP="D:/a/_temp/"
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: delvewheel repair -w {dest_dir} {wheel}
CIBW_BEFORE_BUILD_MACOS: brew reinstall gcc; pip install --only-binary=llvmlite llvmlite
CIBW_ENVIRONMENT_MACOS: MACOSX_DEPLOYMENT_TARGET=`sw_vers -productVersion` SYSTEM_VERSION_COMPAT=0
Expand Down Expand Up @@ -347,7 +352,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, ubuntu-24.04-arm, macos-15, macos-15-intel] # TODO #558 windows-latest]
os: [ubuntu-latest, ubuntu-24.04-arm, macos-15, macos-15-intel, windows-latest]
steps:
- uses: actions/checkout@v7
with:
Expand All @@ -365,7 +370,7 @@ jobs:
uses: msys2/setup-msys2@v2
with:
msystem: UCRT64
update: false
update: true
install: >-
mingw-w64-ucrt-x86_64-gcc
mingw-w64-ucrt-x86_64-ninja
Expand Down
5 changes: 3 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ exclude = [
]

[build-system]
requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2", "setuptools-scm==8.3.1"]
requires = ["scikit-build-core >=0.4.3", "nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'", "nanobind >=1.3.2; sys_platform != 'win32'", "setuptools-scm==8.3.1"]
build-backend = "scikit_build_core.build"

[project]
Expand All @@ -267,7 +267,8 @@ authors = [
license = "GPL-3.0"
dependencies = [
"numpy",
"nanobind"
"nanobind >=1.3.2,<3.0.1; sys_platform == 'win32'",
"nanobind >=1.3.2; sys_platform != 'win32'",
]

[project.optional-dependencies]
Expand Down
Loading