feat: add the Reviews stop to the web book page by roberte777 · Pull Request #2845 · omnibus-library/omnibus

roberte777 · 2026-10-20T21:11:06Z

Summary

Reviews stop after Stats: your card, household summary, other readers
Your card: one-tap half stars, a pencil to edit and a trash can to delete
Spoiler flag lives in the editor; flagged text stays folded until Finished
Title area links to Reviews once two or more readers have rated the book

Test plan

cargo nextest run -p omnibus-frontend --features server
just e2e-ci tests/flows/reviews.spec.ts
just lint

Version

By default a merge to main cuts a patch release. Pick the version update this PR should trigger; labels override the default:

Minor — add the minor version label (vX.Y.Z → vX.(Y+1).0).
Patch — the default; add the patch version label or leave unlabeled (vX.Y.Z → vX.Y.(Z+1)).
No release — add the no release label to skip cutting a release.

If both minor version and patch version are applied, minor version wins. Unlabeled PRs that only touch docs (*.md, docs/) or CI (.github/) skip the release automatically.

Notes

Part of [Reviews] Goodreads-Style Book Reviews #2841: stacked on feat: add the /api/reviews routes, review server functions and MCP book_reviews tool #2843 (db → API → web → mobile → React → iOS)
Book-delete confirmation now counts reviews; the wire field stays ratings
The journal's Markdown field and highlights inserter are shared with reviews

…age objects

… into the editor

codecov · 2026-10-20T21:13:47Z

Codecov Report

❌ Patch coverage is 58.01325% with 317 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
frontend/src/pages/book_detail/reviews.rs	24.32%	84 Missing ⚠️
frontend/src/pages/book_detail/reviews/mine.rs	34.16%	79 Missing ⚠️
frontend/src/pages/book_detail/reviews/writes.rs	80.97%	51 Missing ⚠️
frontend/src/data/reviews.rs	40.38%	31 Missing ⚠️
frontend/src/pages/book_detail/journal_editor.rs	19.44%	29 Missing ⚠️
frontend/src/pages/book_detail/reviews/composer.rs	58.73%	26 Missing ⚠️
frontend/src/pages/book_detail/reviews/stars.rs	71.42%	6 Missing ⚠️
frontend/src/pages/book_detail/marquee.rs	0.00%	5 Missing ⚠️
frontend/src/pages/book_detail/reviews/others.rs	86.36%	3 Missing ⚠️
frontend/src/pages/book_detail/journal/composer.rs	0.00%	1 Missing ⚠️
... and 2 more

📢 Thoughts on this report? Let us know!

github-actions · 2026-10-20T21:14:11Z

cargo-audit

No RustSec advisories found in Cargo.lock ✅

_{Posted by the Rust workflow's security job.}

Copilot

🟡 Changes recommended

Pending saves can discard draft edits, refreshes can restore stale content, and review dialogs need keyboard focus handling.

4 open issues

What changed in this PR

Adds a Reviews section after Stats on the web book page, using the review APIs introduced in #2843.

Changes:

Adds editable reviews, private notes, spoiler controls and household ratings.
Shares Markdown editing and highlight insertion with journals.
Adds review tests and updates navigation and deletion wording.

File	Description
ui_tests/playwright/tests/pages/BookDetailPage.ts	Adds Reviews and seventh stop.
ui_tests/playwright/tests/flows/reviews.spec.ts	Tests review workflows and failures.
ui_tests/playwright/tests/flows/book_detail.spec.ts	Updates navigation and replaces rating coverage.
ui_tests/playwright/tests/fixtures/requestFixtures.ts	Registers review requests.
ui_tests/playwright/tests/fixtures/dataFixtures.ts	Adds review setup and cleanup.
ui_tests/playwright/tests/fixtures/accountFixtures.ts	Adds reader-specific requests.
ui_tests/playwright/tests/data/reviews.ts	Defines review test types.
ui_tests/playwright/tests/data/ratings.ts	Removes obsolete rating types.
ui_tests/playwright/tests/contracts/reviews.ts	Defines review mutation contracts.
ui_tests/playwright/tests/contracts/ratings.ts	Removes obsolete rating contracts.
ui_tests/playwright/tests/components/ReviewsComponent.ts	Adds review selectors and actions.
ui_tests/playwright/tests/components/RatingComponent.ts	Removes replaced rating component.
ui_tests/playwright/tests/apiRequests/ReviewsRequests.ts	Adds review API helpers.
shared/src/deletion.rs	Labels deletion losses as reviews.
frontend/src/pages/book_detail/reviews/writes.rs	Handles mutations and refreshes.
frontend/src/pages/book_detail/reviews/tests.rs	Tests patches and rendered states.
frontend/src/pages/book_detail/reviews/summary.rs	Displays household ratings and jump link.
frontend/src/pages/book_detail/reviews/stars.rs	Adds half-star picker.
frontend/src/pages/book_detail/reviews/others.rs	Displays other readers and spoilers.
frontend/src/pages/book_detail/reviews/mine.rs	Adds personal card and deletion dialog.
frontend/src/pages/book_detail/reviews/composer.rs	Edits public text and private notes.
frontend/src/pages/book_detail/reviews.rs	Coordinates review loading and rendering.
frontend/src/pages/book_detail/mod.rs	Registers Reviews; retains mobile ratings.
frontend/src/pages/book_detail/marquee/tests.rs	Verifies seven-stop navigation.
frontend/src/pages/book_detail/marquee/stats.rs	Removes the old rating widget.
frontend/src/pages/book_detail/marquee/home.rs	Adds household-rating jump link.
frontend/src/pages/book_detail/marquee.rs	Integrates the Reviews stop.
frontend/src/pages/book_detail/journal/entry_card.rs	Uses shared Markdown surface.
frontend/src/pages/book_detail/journal/composer.rs	Uses shared editor and highlight controls.
frontend/src/pages/book_detail/journal.rs	Shares spoiler reveal binding.
frontend/src/pages/book_detail/journal_editor.rs	Extracts reusable editing controls.
frontend/src/pages/book_detail/flow.js	Updates section-count comment only.
frontend/src/data/reviews/tests.rs	Tests mobile transport behavior.
frontend/src/data/reviews.rs	Adds review transports.
frontend/src/data.rs	Exports review operations.
frontend/assets/atrium.css	Styles review surfaces.
.claude/rules/04a-playwright-surfaces.md	Documents seven navigation dots.
.claude/rules/04-playwright.md	Reserves the review test fixture.

_{Review effort: Balanced}

…s section

…reviews moving forward

…saves, and focus the review dialogs

…popover while a review saves

…he replica and queued offline (#2846) ## Summary - Reviews replaces the mobile rating block; the title line links down to it - Reviews read through the local replica, so the section shows offline - Offline writes queue as `review:<uuid>`; queued patches merge per field - Rating writes queued by older builds still replay ## Test plan - [x] `cargo nextest run -p omnibus-frontend --features mobile` - [x] `cargo nextest run -p omnibus-frontend --features server` - [x] `just lint` and `cargo clippy -p omnibus-frontend --features mobile` ## Version By default a merge to `main` cuts a patch release. Pick the version update this PR should trigger; labels override the default: - [ ] **Minor** — add the `minor version` label (`vX.Y.Z` → `vX.(Y+1).0`). - [x] **Patch** — the default; add the `patch version` label or leave unlabeled (`vX.Y.Z` → `vX.Y.(Z+1)`). - [ ] **No release** — add the `no release` label to skip cutting a release. If both `minor version` and `patch version` are applied, `minor version` wins. Unlabeled PRs that only touch docs (`*.md`, `docs/`) or CI (`.github/`) skip the release automatically. ## Notes - Part of #2841: stacked on #2845 (db → API → web → mobile → React → iOS) - The card is the shared web section; this PR adds the mobile chrome around it - A cached review holds private notes, so the account-switch wipe covers it

roberte777 added 5 commits October 20, 2026 15:23

chore: share the journal's markdown field and highlights inserter

6080069

fix: count reviews, not ratings, in the book-delete losses

c965082

feat: add the Reviews stop to the web book page

d219c94

chore: cover book reviews end to end and retire the rating widget's p…

e851fa0

…age objects

feat: move the review card's controls into icons and the spoiler flag…

9f53d41

… into the editor

Copilot AI balanced review requested due to automatic review settings October 20, 2026 21:11

roberte777 self-assigned this Oct 20, 2026

roberte777 added minor version Create the next minor release when this PR merges into main run_ui_tests Forces UI tests to be ran on PRs (as opposed to just merges into main) labels Oct 20, 2026

roberte777 added this pull request to stack #2844 October 20, 2026 21:11

Copilot started reviewing on behalf of roberte777 October 20, 2026 21:11

View session

roberte777 mentioned this pull request Oct 20, 2026

feat: put the Reviews section on the mobile book page, read through the replica and queued offline #2846

Merged

4 of 6 tasks

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread frontend/src/pages/book_detail/reviews/composer.rs

Comment thread frontend/src/pages/book_detail/reviews/writes.rs Outdated

Comment thread frontend/src/pages/book_detail/reviews/mine.rs Outdated

Comment thread frontend/src/pages/book_detail/reviews/mine.rs

github-advanced-security Bot found potential problems Oct 20, 2026

View reviewed changes

Comment thread frontend/src/data/reviews.rs Dismissed

Comment thread frontend/src/data/reviews.rs Dismissed

Comment thread frontend/src/data/reviews.rs Dismissed

roberte777 added 5 commits October 20, 2026 16:38

fix: revert a refused tap to the confirmed review and tidy the review…

5eaad7e

…s section

fix: run review writes on the section's own scope and keep confirmed …

c4fceac

…reviews moving forward

fix: keep review tasks on the page's scope, hold the editor while it …

70c8e98

…saves, and focus the review dialogs

Merge branch 'OMNI-2841/reviews-api-2' into OMNI-2841/reviews-web-3

f19ab48

fix: let the delete dialog go with its trash and hold the highlights …

922ce47

…popover while a review saves

roberte777 merged commit c3e93bd into main Oct 21, 2026
48 checks passed

roberte777 deleted the OMNI-2841/reviews-web-3 branch October 21, 2026 01:12

Navigation Menu

Repository navigation

feat: add the Reviews stop to the web book page - #2845

feat: add the Reviews stop to the web book page#2845
roberte777 merged 10 commits into
OMNI-2841/reviews-api-2from
OMNI-2841/reviews-web-3

roberte777 commented Oct 20, 2026

Uh oh!

codecov Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

roberte777 commented Oct 20, 2026

Summary

Test plan

Version

Notes

Uh oh!

codecov Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cargo-audit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading