[daniele-verducci]

⚠️ Depends on nextcloud/android#17852 [DONE]
⚠️ Depends on nextcloud/Android-SingleSignOn#1096 [DONE]
⚠️ Main on notes-android is broken until nextcloud/Android-SingleSignOn#1104 is merged

Before reviewing this it's needed to:

• merge the 3 PRs above
• release a new singleSignOn lib version
• update the singleSignOnVersion in build.gradle with the new version

(...or build all the dependencies from the respective repositories and point to them)

What's this?

Android implementation of nextcloud/files-clients#132

• Adds a bottom sheet (aligns behaviour & appearance with Files app)
• Adds a detail screen containing activities and share (aligns behaviour & appearance with Files app)
• Implements a versions & activities list, with version restore
• Moves sharing to Detail screen (to align it with Files app)
• Adds option to reach the detail screen from within the editor

🖼️ Screenshots

🏚️ Before	🏡 After
(didn't exist)
(didn't exist)

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

• The content of this PR was partly or fully generated using AI

[codacy-production]

Not up to standards ⛔

🔴 Issues 4 high · 14 medium · 73 minor

Alerts:
⚠ 91 issues (≤ 0 issues of at least minor severity)

Results:
91 new issues

Category	Results
Documentation	69 minor
ErrorProne	4 high
Performance	1 medium
CodeStyle	4 minor
Complexity	13 medium

View in Codacy

🟢 Metrics 241 complexity · 2 duplication

Metric	Results
Complexity	241
Duplication	2

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[github-actions]

APK file: https://github.com/nextcloud/notes-android/actions/runs/37498486797/artifacts/11429388555
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/notes-android/actions/runs/38248370615/artifacts/11747525636
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/notes-android/actions/runs/38396893559/artifacts/11814684541
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/notes-android/actions/runs/38561146362/artifacts/11893339202
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/notes-android/actions/runs/38600254298/artifacts/11913732039
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[daniele-verducci]

Hey @nimishavijay , can you please have a look to the screenshots and let me know what do you think about it? I basically tried to align them to the Files app while respecting the Notes app style, but I may have missed something (not a very good graphic eye here 😅)

[alperozturk96]

what if both of them exist and user wants to tap file version?

[alperozturk96]

do we need calendar instance per item?

[alperozturk96]

why always activity first? cant both of them not null at the same time?

[alperozturk96]

Can we use kotlinx.serialization instead gson? Since Notes app needs to have r8 optimizations.

[alperozturk96]

val ssoAccount =
            SingleAccountHelper.getCurrentSingleSignOnAccount(requireContext())

Can this be done on main thread?

[alperozturk96]

getActivity() instanceof EditNoteActivity editNoteActivity

via this way you can directly access the editNoteActivity no need cast again