Repository navigation
Update to Blockly 13 - #4069
Update to Blockly 13#4069mjgallag wants to merge 41 commits into
Conversation
|
@mjgallag I'm marking this as for-ai2-test so we can get some additional eyes on the update. |
|
@ewpatton Sounds good, that'll get more eyes on it then throwing my test instance out there. FYI @jisqyv I'm going to update it to https://github.com/RaspberryPiFoundation/blockly/releases/tag/blockly-v13.3.0 today as might as well do that before it goes to ai2-test. |
RaspberryPiFoundation/blockly@59fab94 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L217-L219 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L254 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1166-L1171 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1172-L1175 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1187-L1191
https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L148-L152 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L160-L162 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L189-L193 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L195-L197 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L205-L208 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L234-L239 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L301-L304 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L345-L347
Stage the BlocklyPanel element in a hidden div before initializing the workspace. GWT later moves it into the ProjectEditor deck when the editor is added. Blockly measures a hidden workspace using computed CSS, which requires the workspace element to be attached to the document. RaspberryPiFoundation/blockly#8572
Removes staging of BlocklyPanel element in a hidden div before initializing the workspace workaround.
367f7da to
d11f73c
Compare
|
@mjgallag There are reports on the community, that I have confirmed, that if the UI is in dark mode, the dialogs you get for typeblocking are "washed out." |
Blockly 13 switched sprites from PNG to SVG. RaspberryPiFoundation/blockly@2678f58
RaspberryPiFoundation/blockly@09d19d8 Suggestions previously inherited black text from the page body.
31326d3 to
2e43b21
Compare
|
@mjgallag Should I update ai2-test? |
|
@jisqyv I'm going to look at https://community.appinventor.mit.edu/t/begin-testing-release-nb207/176026/10 now, I'll let you know when I'm done. |
OK. I'll wait. |
|
@jisqyv fixed! |
RaspberryPiFoundation/blockly@93856f8 Exclude the search toolbar from our mousedown handler because hideChaff() now closes workspace search.
|
@jisqyv I fixed https://community.appinventor.mit.edu/t/begin-testing-release-nb207/176026/15 ... no rush on updating test though. |
|
@ewpatton I'm not seeing things as black... (I'm not in dark mode) |



What does this PR accomplish?
Description
What does this PR accomplish?
josmas/blockly-plugins#6
mit-cml/blockly-plugins#88
mit-cml/workspace-multiselect#154
I had to map all of the single letter shortcuts due to typeblocking. I went with option/alt as it seemed to lack system conflicts.
Note the Blockly keyboard shortcut help dialog we had in 12 is not in 13 as Blockly did not move it into core from https://github.com/raspberrypifoundation/blockly-keyboard-experimentation.
Context for the changes
If this PR changes anything related to the companion make sure you have used the
ucrbranch. For all other changes usemasteror provide context for having used a different branch.See a summary of git branches in the docs: App Inventor Developer Overview
If your code changes how something works on the device (i.e., it affects the companion):
I have made no changes that affect the companion
I branched from
ucrMy pull request has
ucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
I have made no changes that affect the master branch
I branched from
masterMy pull request has
masteras the baseGeneral items:
ant testspasses on my machine