Repository navigation
feat(wallet-cli): nested command grammar, structured output, confirmations, wizards, exec mode and a read-only mcp server #2147
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,6 +75,7 @@ members = [ | |
| "wallet/wallet-address-generator", # Wallet address generator binary. | ||
| "wallet/wallet-address-generator-lib", # Wallet address generator lib. | ||
| "wallet/wallet-rpc-client", # Wallet RPC communication. | ||
| "wallet/mcp-server", # Read-only MCP server on top of the wallet RPC daemon. | ||
| "wallet/wallet-rpc-daemon", # Wallet RPC daemon binary. | ||
| "wallet/wallet-rpc-lib", # Wallet RPC definitions library. | ||
| "wallet/wallet-test-node", # Node for wallet testing as a library. | ||
|
|
@@ -152,12 +153,14 @@ cfg-if = "1.0" | |
| chacha20poly1305 = "0.10" | ||
| chrono = "0.4" | ||
| clap = "4.5" | ||
| clap_complete = "4.5" | ||
| console-subscriber = "0.5" | ||
| criterion = "0.5" | ||
| crossterm = "0.28" | ||
| csv = "1.3" | ||
| ctor = "0.10" | ||
| derive_more = { version = "1.0", features = ["full"] } | ||
| dialoguer = "0.11" | ||
| directories = "5.0" | ||
| humantime = "2.1" | ||
| dyn-clone = "1.0" | ||
|
|
@@ -232,6 +235,7 @@ reqwest = "0.12" | |
| rfd = { version = "0.15", default-features = false } | ||
| ripemd = "0.1" | ||
| rlimit = "0.10" | ||
| rpassword = "7.2" | ||
| rstest = "0.24" | ||
| rstest_reuse = "0.7" | ||
| rusqlite = "0.34" | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment and path assume npm installs typescript/knip into the repository root's node_modules, but the "Install TypeScript & Knip" step runs with working-directory ./wasm-wrappers, which has no package.json (neither does the repo root — only wasm-wrappers/js-bindings-test/package.json exists).
npm install <pkg>without a package.json installs into the current working directory, so node_modules will most likely be created at ./wasm-wrappers/node_modules, not $GITHUB_WORKSPACE/node_modules. These steps will then fail with "not found". Either install at the root explicitly (cd to $GITHUB_WORKSPACE or usenpm install --prefix "$GITHUB_WORKSPACE"), or reference "$GITHUB_WORKSPACE/wasm-wrappers/node_modules/.bin/tsc".Suggestion:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install step runs at the repository root without a working-directory override, so typescript and knip land in the root node_modules. The steps now invoke both binaries through the root node_modules/.bin path explicitly, which no longer depends on the runner image putting that directory on PATH.