Repository navigation
In artist core, remove _store field and flatten nested fields - #176
Open
fettuccinae wants to merge 8 commits into
Open
fettuccinae wants to merge 8 commits into
fettuccinae wants to merge 8 commits into
Conversation
Member
|
Please provide commit messages :) (6249b26 for example should have a message explaining how |
…oesnt show up in search results. In query_result_to_dict, we are currently using a tempvals set to store the value of a field. This works well for fields where duplication is redundant but in the case of same number of mediums.track_count, duplicate values are removed and the wrong number of tracks is sent for indexing. We can fix this by using a list to store tempvals, and after transformfuncs are applied, its de-duplicated(trackmediums is an exception) and added to the dict. Changed tempvals in query_result_to_dict from set to a list. Modified test data to test for release with same number of tracks on 2 mediums. Modified transformfuncs to be compatible with list.
add preserve_og flag to fields, add all retreivable fields to searchFields, add index_partialdate_to_string method
Author
|
Hey, sorry, I forgot to update the description of this PR. I have copied the PR description into commit message, will make sure to add them from here on. |
fettuccinae
changed the title
…tructor Instead of creating parallel arrays for nested fields(here alias list), We can create a JSON string for it. objconverter on that particular nested field will take the object and returns a list of JSON strings for the nested field.
When comparing with previous configset result, I found that the differences was in tag_count when 0, didnt show up and gender names were capitalized
…ag_name and type_name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #172 and #175.
This PR incorporates the changes introduced in the configset PR into the indexer.
Earlier we were using
convert.convert_artistto buildstore(an XML blob), which was then deserialized by response writers.Changes
A new SearchField argument
objconverteris added which builds a field's value from the entity object itself.SearchArtistnow no longer emits_store, every path that existed only asextrapathsis now moved tofield.tagis now represented by two parallel arrays as eachtaghas itstag_count.aliasesbecomesalias_json, built from the alias entity's field values bytfs.aliases_to_json.Effect
The response writer now builds the MMD
Artistobject from these fields, mirroring the logic inwscompat.convert_artist.