Repository navigation
SEARCH-666: Use quality names rather than numeric IDs - #158
Open
reosarevok wants to merge 1 commit into
Open
reosarevok wants to merge 1 commit into
reosarevok wants to merge 1 commit into
Conversation
reosarevok
force-pushed
the
SEARCH-666
branch
from
February 2, 2023 14:32
c62cf6b to
9cb1877
Compare
reosarevok
force-pushed
the
SEARCH-666
branch
from
January 30, 2026 12:10
dedd6ed to
4333c4e
Compare
This matches what we do elsewhere in the API, matches what was listed in our documentation, and removes the split between -1 (default) and 1 (normal) which we don't generally expose to data users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SEARCH-666
Problem
Our documentation claims that you can search release quality using the words "high", "normal" and "low". That's not the case though - for some reason, release indexing was implemented by just indexing the quality as a number straight from the DB.
This causes several problems:
Solution
Add a transform function
quality_to_stringthat maps 0 to low, 2 to high, and other options (that is, -1 and 1) to normal. This matches what we do elsewhere in the API, matches what was listed in our documentation, and removes the split between -1 (default) and 1 (normal) which we don't generally expose to data users.Testing
Updated the testing data so that not all the qualities are -1, otherwise just letting the existing test do its thing.
Actions