Skip to content

MBS-12368: Add annotations, rels and aliases to genre WS - #2518

Open
reosarevok wants to merge 1 commit into
metabrainz:masterfrom
reosarevok:genre-ws-extras
Open

reosarevok wants to merge 1 commit into
metabrainz:masterfrom
reosarevok:genre-ws-extras

Conversation

@reosarevok

@reosarevok reosarevok commented May 11, 2022 •

Copy link
Copy Markdown
Member

Implement MBS-12368

This also allows includes in the non-text genre list, since we had specifically talked about that as the reason we wanted to have limit / offset there while having a names-only text list.

mmd-schema changes (merged): metabrainz/mmd-schema#27

@reosarevok

Copy link
Copy Markdown
Member Author

By now the only perl test failure seems to be the expected validation one because of MMD changes.

@reosarevok reosarevok changed the title Add annotations, rels and aliases to genre WS MBS-12368: Add annotations, rels and aliases to genre WS May 12, 2022
@reosarevok
reosarevok changed the base branch from schema-change-2022-q2 to master June 8, 2022 09:59
@yvanzo

yvanzo commented Jun 29, 2022 •

Copy link
Copy Markdown
Contributor

For testing it mmd-schema is retrieved through mb-solr to make sure it returns similar results. So it requires updating mb-solr first. It seems worth doing the related changes to sir and mbsssss at the same time.

@reosarevok

Copy link
Copy Markdown
Member Author

Sounds good to me. I can try to look into that next week, if you don't find time before that :)

@reosarevok

Copy link
Copy Markdown
Member Author

mbsssss: metabrainz/mbsssss#61
sir: metabrainz/sir#136 / metabrainz/sir#137 (needs running scripts)

First try and I might have missed some stuff though :)

@petitminion

Copy link
Copy Markdown

hello @reosarevok :)

I don't know if you got our query in there : https://tickets.metabrainz.org/browse/MBS-12368. So I tried it in here because this seems to have been left in a old milestone and maybe forgotten.

Do you plan to implement this ? We would love to use it in funkwhale. If we can do anything to help let me know.

Thanks ! :)

@reosarevok

Copy link
Copy Markdown
Member Author

It's not forgotten, but sadly it cannot be merged until we can update the search server to work alongside it, and that is quite a process since it's still in Python 2 and needs to be migrated... Sorry about the wait!

@petitminion

Copy link
Copy Markdown

Okey thanks a lot for answering :) And good luck with the migration of the search server o/

@arli2001

Copy link
Copy Markdown

Hi, any news on this pull request? Any help needed?
Thanks a lot :)

@mwiencek

Copy link
Copy Markdown
Member

Tests are already running mb-solr v4.1.0 which should have the necessary mmd-schema changes. This doesn't depend on any search changes otherwise.

@reosarevok

Copy link
Copy Markdown
Member Author

Rebased this on our latest code - @mwiencek, IIRC the point was we wanted to wait and do the search bits linked from #2518 (comment) at the same time although to be honest it might make sense to release this if it works and just update search to follow it later, if it's hard to do now.

This also allows includes in the non-text genre list,
since we had specifically talked about that as the reason
we wanted to have limit / offset there while having a names-only
text list.
@phw

phw commented Jun 29, 2026

Copy link
Copy Markdown
Member

@reosarevok I'm all in favor of at least releasing this part. Being able to get genre details in a direct lookup would already be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New feature Non urgent new stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants