Repository navigation
MBS-12368: Add annotations, rels and aliases to genre WS - #2518
reosarevok wants to merge 1 commit into
Conversation
73528ca to
7414e31
Compare
|
By now the only perl test failure seems to be the expected validation one because of MMD changes. |
7414e31 to
b84a50d
Compare
b84a50d to
b74a1fa
Compare
b74a1fa to
1599415
Compare
1599415 to
98fe9ff
Compare
98fe9ff to
64e4550
Compare
|
For testing it |
|
Sounds good to me. I can try to look into that next week, if you don't find time before that :) |
|
mbsssss: metabrainz/mbsssss#61 First try and I might have missed some stuff though :) |
64e4550 to
521d008
Compare
521d008 to
9a459ae
Compare
|
hello @reosarevok :) I don't know if you got our query in there : https://tickets.metabrainz.org/browse/MBS-12368. So I tried it in here because this seems to have been left in a old milestone and maybe forgotten. Do you plan to implement this ? We would love to use it in funkwhale. If we can do anything to help let me know. Thanks ! :) |
|
It's not forgotten, but sadly it cannot be merged until we can update the search server to work alongside it, and that is quite a process since it's still in Python 2 and needs to be migrated... Sorry about the wait! |
|
Okey thanks a lot for answering :) And good luck with the migration of the search server o/ |
9a459ae to
a864605
Compare
a864605 to
ac3013f
Compare
|
Hi, any news on this pull request? Any help needed? |
|
Tests are already running mb-solr v4.1.0 which should have the necessary mmd-schema changes. This doesn't depend on any search changes otherwise. |
ac3013f to
1c890da
Compare
|
Rebased this on our latest code - @mwiencek, IIRC the point was we wanted to wait and do the search bits linked from #2518 (comment) at the same time although to be honest it might make sense to release this if it works and just update search to follow it later, if it's hard to do now. |
1c890da to
5c0f267
Compare
This also allows includes in the non-text genre list, since we had specifically talked about that as the reason we wanted to have limit / offset there while having a names-only text list.
5c0f267 to
624358b
Compare
|
@reosarevok I'm all in favor of at least releasing this part. Being able to get genre details in a direct lookup would already be great. |
Implement MBS-12368
This also allows includes in the non-text genre list, since we had specifically talked about that as the reason we wanted to have limit / offset there while having a names-only text list.
mmd-schema changes (merged): metabrainz/mmd-schema#27