Repository navigation
Newsletter: separate email subject/preview from SEO title, fix footer - #1344
Merged
Merged
Conversation
Optional `subject` and `previewText` frontmatter override `title` and `excerpt` in the Resend broadcast only, so search titles and inbox subject lines can be written for their own audiences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TrbJoZMm1Pmxc4FvUCRckM
…oter - Add a "hit reply" prompt to the newsletter sign-off - Share link goes to /subscribe instead of the /newsletter archive - Layout's mikebifulco.com link goes to the homepage, so /newsletter isn't linked twice - Cover image alt text uses the email subject (falling back to title) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TrbJoZMm1Pmxc4FvUCRckM
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TrbJoZMm1Pmxc4FvUCRckM
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the newsletter inbox-copy, footer messaging, and dependency updates.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
Separates newsletter inbox copy from web and SEO metadata in the Resend publishing flow, updates email footer messaging, and refreshes dependencies.
Changes:
- Adds optional
subjectandpreviewTextfields with title/excerpt fallbacks; reuses the resolved subject for cover-image alt text. - Adds a reply prompt and updates footer links to the subscription page and homepage.
- Updates dependencies, aligns the Next.js override, and switches generated type imports to build-output paths.
| File | Description |
|---|---|
src/utils/email/templates/NewsletterEmail.tsx |
Uses title-based image alt text and updates reply/share messaging. |
src/utils/email/templates/EmailLayout.tsx |
Points the site-name footer link to the homepage. |
src/data/content-types.ts |
Defines optional newsletter subject and preview fields. |
scripts/sync-newsletter-to-resend.ts |
Applies inbox-copy overrides when rendering and syncing broadcasts. |
pnpm-workspace.yaml |
Aligns the Next.js override to 16.4.4. |
pnpm-lock.yaml |
Records updated dependency resolutions. |
package.json |
Updates application and development dependencies. |
next-env.d.ts |
References generated types under .next/types. |
Review effort: Balanced
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inbox copy separate from search copy
subjectandpreviewTextfrontmatter on newsletters. When present, they overridetitleandexcerptin the Resend broadcast only. The web page, OG cards, and search metadata keep usingtitle/excerpt.subject ?? title) and drives both the broadcast subject and the cover image alt text.Footer
/subscribeinstead of linking the/newsletterarchive.mikebifulco.comlink points at the homepage, so/newsletterisn't linked twice.Dependencies
pnpm up -i -Lbumps, including Next 16.4.4, tRPC 11.22.1, react-email 6.11.6, resend 6.37.0, and posthog.pnpm-workspace.yamloverride bumped tonext: 16.4.4to match. It was still pinning 16.4.3.Test plan
tsc --noEmitpnpm build: 739 pagesNewsletterEmail. Links are only/subscribe, the homepage, and unsubscribe; alt text uses the title.subject/previewTextset and check the broadcast in Resend before sending.🤖 Generated with Claude Code
https://claude.ai/code/session_01TrbJoZMm1Pmxc4FvUCRckM