Repository navigation
test(page): align 3 tests with fixed source behavior - #968
deepin-bot[bot] merged 1 commit into
Conversation
UT_PageDriverControl_closeEvent_Done: close reentry was eliminated, closeEvent now emits refreshInfo exactly once instead of twice. UT_PageDriverControl_isRunning_visible: isRunning matches the constructor-set objectName "PageDriverControl", not the nonexistent "PageDriverControlWindow". UT_PageDriverManager_networkIsOnline: Qt6 branch returns reachability != Disconnected, so Online/Unknown are online and Disconnected is offline. 同步三个单测与源码缺陷修复后的行为:closeEvent 重入消除后 refreshInfo 仅触发一次;isRunning 匹配构造函数设置的 objectName; networkIsOnline 修正反置判断,Online/Unknown 在线、Disconnected 离线。 Log: 修复与源码行为不一致的三个单测 Influence: 仅测试代码,无生产逻辑变更;本地 3281/3281 全部通过。
Reviewer's GuideTestsUpdate the Done close-event test and file copyright notice to reflect the single refresh and accepted close event after re-entry was eliminated.
Make the visible isRunning test use the constructor’s PageDriverControl object name and verify that renaming the window makes it unrecognized.
Align the networkIsOnline test expectations with the fixed reachability behavior: Online and Unknown are online, while Disconnected is offline.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: [] 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: add-uos, lzwind The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
问题 / Problem
流水线 UT 失败 3 个用例(task-25710492 / 9a2caa8 合入后):
UT_PageDriverControl.UT_PageDriverControl_closeEvent_DoneUT_PageDriverControl.UT_PageDriverControl_isRunning_visibleUT_PageDriverManager_Misc.UT_PageDriverManager_networkIsOnline三个用例均为在
9a2caa84(7 项源码缺陷修复)之前编写,固化的是修复前的旧缺陷行为(networkIsOnline 用例注释中自标"逻辑疑似反转(Mode 5 缺陷候选)"),源码修复合入后断言全部反转失效。修复 / Fix(仅测试代码,无生产逻辑变更)
closeEvent_DoneisRunning_visible"PageDriverControlWindow""PageDriverControl"且窗口可见networkIsOnline== Disconnected反置:Online→false!= Disconnected:Online/Unknown→true、Disconnected→false另更新
ut_pagedrivercontrol.cppSPDX 版权年份 2022 → 2022 - 2026。自测 / Verification
tests/test-prj-running.sh(Qt6):3281/3281 全部通过,0 失败Summary by Sourcery
Update page driver tests to reflect corrected source behavior and restore the full test suite.
Enhancements:
Tests:
Chores: