Repository navigation
Bundle the GStreamer audio plugins in the Arch AppImage - #43
Merged
Merged
Conversation
WebKitGTK plays audio through GStreamer, but `webkit2gtk-4.1` only depends on the GStreamer libraries. The plugin packages were never installed in the packaging container, so `quick-sharun` had nothing to deploy and the AppImage logged `GStreamer element autoaudiosink not found`. - **Packages:** add `gst-plugins-base`, `gst-plugins-good` and `gst-plugin-pipewire` to the default `extra-pacman-packages`. `autoaudiosink` lives in the `autodetect` plugin from `gst-plugins-good`. - **Deploy:** set `DEPLOY_GSTREAMER=1` for the assemble step so the plugins are always copied, not only when `quick-sharun` detects a linked `libgstreamer`. - **Guard:** fail the build if `libgstautodetect.so` is not in the AppDir after `quick-sharun` runs. Consumers that pass their own `extra-pacman-packages` replace the default and need to include these three packages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gst-plugins-base,gst-plugins-goodandgst-plugin-pipewireby default. WebKitGTK plays audio through GStreamer, andwebkit2gtk-4.1only depends on the GStreamer libraries, soquick-sharunhad no plugins to deploy and packaged apps loggedGStreamer element autoaudiosink not found.DEPLOY_GSTREAMER=1is set for the assemble step so the plugins are always copied into the AppDir.libgstautodetect.so(which providesautoaudiosink) is missing from the AppDir afterquick-sharunruns.folio,emoji-nook,jarandlieutenant-fizzcall this workflow at@mainwithout overridingextra-pacman-packages, so all four pick up the change. A consumer that passes its ownextra-pacman-packagesreplaces the default and needs to include the three packages.Test plan
.deb: the guard passed andquick-sharun --testwent OKlibgstautodetect.so,libgstpipewire.soandlibgstalsa.soare present inAppDir/lib/gstreamer-1.0/autoaudiosinkmessage and noGLib-GObject-CRITICALlines; only the harmlesscanberra-gtk-modulenotice remains