Repository navigation
test(oauth-provider): unit coverage for base64url helpers - #1819
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1818
Adds
packages/decap-cms-oauth-provider/src/__tests__/base64url.spec.tscovering the previously-untested base64url helpers:bytesToBase64Url/base64UrlToBytesround-trip for empty, single-byte, and multi-byte inputs+,/, or=; explicit check that a byte sequence which produces both+and/in standard base64 is correctly mapped to-/_textToBase64Url/base64UrlToTextround-trip for ASCII and multi-byte UTF-8 (including emoji and accented characters)base64UrlToBytespadding reconstruction for input lengths oflength % 4= 0, 2, 3 (round-trips correctly) and 1 (asserted to throw, since no valid base64(url) string has length % 4 === 1)No changes to
base64url.ts— test-only PR, matches the existing__tests__/*.spec.tsstyle used by sibling modules in the package (state.spec.ts,html.spec.ts, etc.).Gate:
type-check,lint, andtest:unitall pass locally (full monorepo run), including via the repo's pre-push husky hook.