Repository navigation
Conversation
Signed-off-by: zjy365 <3161362058@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop currently blocks kubeconfig access, initialization, and rotation for the User CR named
admin. Add the server-onlydesktop.auth.adminKubeconfigEnabledswitch (Helm:desktopConfig.adminKubeconfigEnabled), defaulting tofalse, so deployments can explicitly opt in. Only the booleantrueenables access; missing, unloaded, and invalid configuration keeps the current restriction.Use one policy for the existing getter/initialization guard and rotation API. Authentication and ordinary users, including
ns-admin, retain their existing behavior. Exclude the new field from client configuration and update the YAML defaults, both Helm values files, ConfigMap, and configuration guides. Helm rendering also rejects non-boolean opt-ins.The switch removes only Desktop's restriction; existing credentials, controller behavior, and RBAC still determine the result. Helm config updates roll the Desktop Pods; direct ConfigMap edits require a restart. Disabling the switch does not revoke kubeconfigs already issued. The frontend rotation visibility switch remains independent.
Validation
Verified in an isolated worktree based on current
upstream/main:pnpm --filter desktop test:ci: 386 passed, 51 skipped, 2 todo. Includes 51 KC policy/API cases covering enabled/disabled/invalid configuration, initialization, regional/app/global token access, invalid credentials, request overrides, namespace handling, rotation, cluster errors, and client configuration exclusion.pnpm exec tsc -p desktop/tsconfig.json --noEmit --incremental false: passed.git diff --check: passed.false, explicit booleantrueis enabled, and string/numeric/null values remain disabled.Kubernetes operations were mocked in tests; no live cluster or credentials were changed.