Skip to content

Fix: copy_log_function is removed if exists when reset - #62

Merged
s-cooper18 merged 1 commit into
mainfrom
s-cooper18/reset-removes-copy-function-test
Sep 16, 2026
Merged

Fix: copy_log_function is removed if exists when reset#62
s-cooper18 merged 1 commit into
mainfrom
s-cooper18/reset-removes-copy-function-test

Conversation

@s-cooper18

@s-cooper18 s-cooper18 commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes such that when using the CHANGE_LOG sync strategy, the change_log_copy_function is deleted during cleanup.

@s-cooper18
s-cooper18 force-pushed the s-cooper18/reset-removes-copy-function-test branch from 11d17bb to 8812973 Compare September 16, 2026 04:38
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

Coverage Report Results

Name Stmts Miss Branch BrPart Cover
src/psycopack/__init__.py 9 0 0 0 100%
src/psycopack/_commands.py 230 0 38 0 100%
src/psycopack/_conn.py 5 0 0 0 100%
src/psycopack/_const.py 3 0 0 0 100%
src/psycopack/_cur.py 24 0 2 0 100%
src/psycopack/_identifiers.py 12 0 2 0 100%
src/psycopack/_introspect.py 199 0 20 0 100%
src/psycopack/_logging.py 2 0 0 0 100%
src/psycopack/_partition.py 16 0 0 0 100%
src/psycopack/_psycopg.py 5 0 0 0 100%
src/psycopack/_registry.py 88 0 12 0 100%
src/psycopack/_repack.py 468 2 172 5 99%
src/psycopack/_sync_strategy.py 4 0 0 0 100%
src/psycopack/_tracker.py 180 0 42 0 100%
tests/conftest.py 19 0 0 0 100%
tests/factories.py 41 0 10 0 100%
tests/test_cur.py 20 0 2 0 100%
tests/test_fixtures.py 5 0 0 0 100%
tests/test_package.py 3 0 0 0 100%
tests/test_repack.py 1210 0 24 0 100%
TOTAL 2543 2 324 5 99%

1 empty file skipped.

@s-cooper18
s-cooper18 force-pushed the s-cooper18/reset-removes-copy-function-test branch 2 times, most recently from 9b2d531 to f034a8c Compare September 16, 2026 04:42
@s-cooper18 s-cooper18 changed the title Add check that copy_log_function is removed when reset Fix: copy_log_function is removed if exists when reset Sep 16, 2026
@s-cooper18
s-cooper18 marked this pull request as ready for review September 16, 2026 04:49
@s-cooper18
s-cooper18 requested a review from a team as a code owner September 16, 2026 04:49
timb07
timb07 approved these changes Sep 16, 2026
View reviewed changes

@timb07 timb07 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Oh, except has the code coverage of _repack.py gone down?

@s-cooper18
Fix: copy_log_function is removed if exists when reset
16dce4c 
Resolve bug where if using the Change Log sync strategy, the
change_log_copy_function will not be cleaned up.
@s-cooper18
s-cooper18 force-pushed the s-cooper18/reset-removes-copy-function-test branch from f034a8c to 16dce4c Compare September 16, 2026 05:06
@s-cooper18

s-cooper18 commented Sep 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Oh, except has the code coverage of _repack.py gone down?

I'm not quite sure why. It could be the fact that it is spread across two lines for the spacing? Or the assertion not being tested except via mypy?

@s-cooper18
s-cooper18 merged commit 68a6833 into main Sep 16, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timb07 timb07 timb07 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@s-cooper18 @timb07