Skip to content

Fix crash on quit while the Open With menu is being populated #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurplel merged 2 commits into from
Nov 4, 2026
Merged

Fix crash on quit while the Open With menu is being populated #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57e1f9b
Fix crash on quit while the Open With menu is being populated
AndyOrbis Nov 3, 2026
2d42321
Don't block window destruction on the Open With task
AndyOrbis Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include "qvwin32functions.h"

#include <QCommandLineParser>
#include <QThreadPool>

int main(int argc, char *argv[])
{
Expand Down Expand Up @@ -35,5 +36,8 @@ int main(int argc, char *argv[])
if (!parser.positionalArguments().isEmpty())
QVApplication::openFile(window, parser.positionalArguments().constFirst(), true);

return QApplication::exec();
const int ret = QApplication::exec();
// Background tasks create QPixmaps; they must finish while the application object still exists.
QThreadPool::globalInstance()->waitForDone();
return ret;
}
7 changes: 3 additions & 4 deletions src/mainwindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,9 @@ void MainWindow::disableActions()

void MainWindow::requestPopulateOpenWithMenu()
{
openWithFutureWatcher.setFuture(QtConcurrent::run([&] {
const auto &curFilePath = getCurrentFileDetails().fileInfo.absoluteFilePath();
return OpenWith::getOpenWithItems(curFilePath);
}));
const QString curFilePath = getCurrentFileDetails().fileInfo.absoluteFilePath();
openWithFutureWatcher.setFuture(QtConcurrent::run(
[curFilePath] { return OpenWith::getOpenWithItems(curFilePath); }));
}

void MainWindow::populateOpenWithMenu(const QList<OpenWith::OpenWithItem> openWithItems)
Expand Down