Repository navigation
refactor: Complete native Copilot migration and instruction remediation - #779
Conversation
- Archive Local entrypoints and adopt native Agent Host interactions - Add fail-closed worker readiness and SDK telemetry acceptance - Preserve project artifacts, human gates and specialist-owned models Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Recover the original plan and add delegable delivery artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Resolve the Prettier failure reported by CI for issue #769. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apply formatter-owned table alignment without changing audit content. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require linked override-free dispatch evidence for current SDK labels. Retain fail-closed readiness checks and add regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make the nonce-only ACK contract explicit in delegated main agent bodies. Retain tool-free stops and execution gates; cover the contract with regression tests. Refs #773 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove active model and effort pins and update coupled policy validators. Separate initial routing checks from complete same-worker readiness. Keep unsupported Auto telemetry blocked pending a fresh runtime capture. Refs #773 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept observed unpinned session inheritance only when worker and parent models agree. Align handshake parsing and prompts with captured SDK output; keep operator Auto unverified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Verify named-worker identity, linked tool-free turns and the same-worker ACK. Treat models, effort, picker selection and model-source telemetry as diagnostics only. Update runtime guidance, smoke acceptance, provenance metadata and regression tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept omitted task mode only with attributed synchronous runtime proof. Validate internal tool turns within one worker interaction and preserve strict JSON output. Align telemetry and clarify reviewer input, output and request identity rules. Refs #767, #773 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Enable direct WORKER_EXECUTE dispatch (--phase execute) - Make record-review.mjs resilient to fences, traces_to, IDs, and log flush - Fix profile_debug_log.py event ordering and per-worker first-input metrics - Complete PRD, backlog, smoke acceptance, and telemetry verification Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Critical shared-guidance conflicts block default direct dispatch; reconcile execution contracts while preserving approval and attribution checks.
6 open issues
Reconcile direct dispatch with the shared execution handshake contract · New Align startup instructions with diagnostic-only handshake behavior · New Scope tool-free continuation requirements to diagnostic handshakes · New Clarify manual batch output versus automatic per-pass files · New Update migration guidance for direct dispatch and diagnostics · New Remove unsupported model-attestation requirement from feature description · New
What changed in this PR
Reopens the APEX migration to the Copilot SDK harness in VS Code, including Autopilot support.
Changes:
- Archives legacy prompt adapters and introduces canonical manual skills.
- Updates worker routing, native interactions, reviews, hooks, and telemetry.
- Revises validators, tests, schemas, CI, and migration acceptance plans.
| File | Description |
|---|---|
tools/tests/scripts/test_validate_review_ceiling.py |
Tests rejection of missing budget evidence. |
tools/tests/scripts/test_validate_question_batching.py |
Updates native-form validation assertions. |
tools/tests/scripts/test_skill_ownership.mjs |
Checks legacy adapter archival. |
tools/tests/scripts/test_risk_authorization.mjs |
Updates supporting-input assertions. |
tools/tests/scripts/test_phase_a_runtime_guidance.mjs |
Uses native SDK session fixtures. |
tools/tests/scripts/test_guidance_remediation.mjs |
Updates routing and recovery assertions. |
tools/tests/scripts/test_execution_subagent_contract.mjs |
Tests the active execution contract. |
tools/tests/scripts/test_context_baseline.mjs |
Removes retired prompt expectations. |
tools/tests/lib/npm-script-graph.test.mjs |
Expects no active prompt sources. |
tools/tests/exec-plans/active/apex-workflow-audit.md |
Links historical guidance to its archive. |
tools/tests/bats/subagent-validation.bats |
Covers SDK responses and advisories. |
tools/scripts/validate-skills.mjs |
Updates replacement entry-point guidance. |
tools/scripts/validate-orphaned-content.mjs |
Removes retired prompt inputs. |
tools/scripts/validate-no-hardcoded-counts.mjs |
Excludes archived content. |
tools/scripts/validate-models.mjs |
Allows absent legacy model pins. |
tools/scripts/validate-mcp-tool-refs.mjs |
Stops scanning retired prompt roots. |
tools/scripts/validate-instruction-checks.mjs |
Limits scanning to active guidance. |
tools/scripts/validate-explorer-graph.mjs |
Removes retired source directories. |
tools/scripts/validate-agent-registry.mjs |
Handles optional legacy model mirrors. |
tools/scripts/validate_question_batching.py |
Validates native structured forms. |
tools/scripts/snapshot-agent-context.sh |
Removes retired prompt snapshot targets. |
tools/scripts/safe-shell.mjs |
Updates scanning and input-tool guidance. |
tools/scripts/lint-json.mjs |
Excludes archived JSON. |
tools/scripts/generate-model-catalog.mjs |
Clarifies legacy-pin generation. |
tools/scripts/generate-explorer-graph.mjs |
Represents the built-in reviewer. |
tools/scripts/diff-context-baseline.sh |
Removes retired prompt categories. |
tools/scripts/check-repository-links.mjs |
Skips missing cached paths. |
tools/scripts/_lib/paths.mjs |
Clears active prompt sources. |
tools/scripts/_lib/model-helpers.mjs |
Clarifies legacy assignment metadata. |
tools/schemas/workflow-graph.schema.json |
Distinguishes automatic and manual reviewers. |
tools/schemas/model-catalog.schema.json |
Supports descriptive runtime model identifiers. |
tools/schemas/agent-scorecard.schema.json |
Updates the assessment reference. |
tools/schemas/agent-registry.schema.json |
Makes legacy model metadata optional. |
tools/registry/count-manifest.json |
Removes retired prompt inventory tracking. |
tools/plans/copilot-harness-migration/roadmap.md |
Defines staged migration acceptance. |
tools/plans/copilot-harness-migration/issues/CHM-08-release-readiness.md |
Records release acceptance requirements. |
tools/plans/copilot-harness-migration/issues/CHM-07-published-docs.md |
Defines documentation acceptance scope. |
tools/plans/copilot-harness-migration/issues/CHM-06-observability.md |
Defines telemetry acceptance; nit: model-identity requirements conflict with strict validation accepting missing model metadata. |
tools/plans/copilot-harness-migration/issues/CHM-05-mcp-hooks.md |
Defines MCP and hook verification. |
tools/plans/copilot-harness-migration/issues/CHM-03-worker-readiness.md |
Defines worker runtime verification. |
tools/plans/copilot-harness-migration/issues/CHM-02-source-acceptance.md |
Defines revision-bound source acceptance. |
tools/plans/copilot-harness-migration/issues/CHM-01-ci-format.md |
Scopes formatting remediation. |
README.md |
Introduces SDK entry points; nit: mandatory continuation claims do not distinguish diagnostic handshakes from direct execution attribution. |
package.json |
Exposes worker-readiness verification. |
eslint.config.mjs |
Excludes archived JavaScript. |
CHANGELOG.md |
Documents migration; nits: checklist incorrectly requires handshake/model evidence, and feature text promises model attestation the verifier no longer enforces. |
AGENTS.md |
Updates runtime guidance; critical: mandatory tool-free continuation conflicts with default direct dispatch. |
.github/workflows/ci.yml |
Adds Python setup for executable tooling tests. |
.github/terminology-blocklist.json |
Excludes historical terminology. |
.github/skills/README.md |
Updates canonical manual skill names. |
.github/skills/apex-workflow-start/SKILL.md |
Adds start/resume entry; critical: unconditional handshake requirement conflicts with default direct dispatch. |
.github/skills/apex-workflow-engine/templates/workflow-graph.json |
Selects the built-in automatic reviewer. |
.github/skills/apex-workflow-engine/SKILL.md |
Updates dispatch and entry-point references. |
.github/skills/apex-workflow-engine/references/review-imported-iac.md |
Removes adapter dependency and updates input guidance. |
.github/skills/apex-workflow-engine/references/project-wide-review.md |
Inventories manual skills instead of prompts. |
.github/skills/apex-workflow-engine/references/operational-safety.md |
Updates SDK ownership and worker boundaries. |
.github/skills/apex-workflow-engine/references/handoff-validation-rules.md |
Recognizes the built-in reviewer. |
.github/skills/apex-iac-common/references/placeholder-scan-protocol.md |
Updates input-tool references. |
.github/skills/apex-iac-common/references/iac-planner-approval-gate.md |
Updates decision-panel guidance. |
.github/skills/apex-iac-common/references/deploy-validation-checklist.md |
Updates placeholder-input guidance. |
.github/skills/apex-iac-common/references/deploy-shared-workflow.md |
Updates deployment approval interactions. |
.github/skills/apex-iac-common/references/codegen-shared-workflow.md |
Updates native input and batching guidance. |
.github/skills/apex-iac-common/references/codegen-do-dont.md |
Updates interaction and reviewer terminology. |
.github/skills/apex-golden-principles/references/principles.md |
Updates independent-review boundaries. |
.github/skills/apex-github-operations/SKILL.md |
Links the canonical commit entry point. |
.github/skills/apex-github-operations/references/merge-sensei-free-pr.md |
Replaces retired authoring references. |
.github/skills/apex-github-operations/references/git-commit.md |
Updates PR-decision input guidance. |
.github/skills/apex-git-commit/SKILL.md |
Adds the manual commit entry point. |
.github/skills/apex-debug-log-export/SKILL.md |
Adds the native-log export entry point. |
.github/skills/apex-context-management/SKILL.md |
Updates native-log prerequisites and references. |
.github/skills/apex-context-management/references/context-audit.md |
Uses repository-scoped native logs. |
.github/skills/apex-context-management/references/audit-setup.md |
Documents native-log discovery and dependencies. |
.github/skills/apex-azure-governance-discovery/references/resume-checks.md |
Uses model-policy cache terminology. |
.github/skills/apex-azure-governance-discovery/references/reconciliation-disposition.md |
Returns recovery to the interactive parent. |
.github/skills/apex-azure-governance-discovery/references/inline-resolution-gate.md |
Updates batched-input guidance. |
.github/skills/apex-azure-governance-discovery/references/baseline-check.md |
Updates baseline-selection interactions. |
.github/skills/apex-azure-defaults/references/vnet-planning.md |
Updates network-planning interactions. |
.github/skills/apex-azure-defaults/references/plan-design-decisions.md |
Updates design-panel guidance. |
.github/skills/apex-azure-defaults/references/cost-estimate-parent-contract.md |
Makes worker routing model-neutral. |
.github/skills/apex-azure-defaults/references/cost-alerts-baseline.md |
Updates missing-email input guidance. |
.github/skills/apex-azure-defaults/references/adversarial-review-deep.md |
Separates review persistence; nit: manual batch guidance expects per-pass files instead of its single consolidated output. |
.github/skills/apex-azure-artifacts/templates/01-requirements.template.md |
Replaces retired prompt attribution. |
.github/skills/apex-agent-authoring/SKILL.md |
Updates unpinned-agent authoring guidance. |
.github/skills/apex-agent-authoring/references/runtime-guardrails.md |
Updates execution and reviewer recovery contracts. |
.github/skills/apex-agent-authoring/references/assess-github-folder.md |
Removes the retired adapter reference. |
.github/skills/apex-agent-authoring/references/assess-agents.md |
Updates assessment links and interaction terminology. |
.github/skills/apex-agent-authoring/references/agent-file-structure.md |
Clarifies SDK routing and archived metadata boundaries. |
.github/instructions/sku-manifest.instructions.md |
Updates preference-collection guidance. |
.github/instructions/references/precedence-matrix.md |
Removes active prompt instruction layering. |
.github/instructions/no-interactive-shell.instructions.md |
Updates active scope and input-tool references. |
.github/instructions/markdown.instructions.md |
Removes retired prompt documentation scope. |
.github/instructions/context-optimization.instructions.md |
Clarifies archived prompt boundaries. |
.github/instructions/agent-skills.instructions.md |
Documents canonical SDK manual entry points. |
.github/instructions/agent-operating-frame.instructions.md |
Updates delegation, review, and runtime boundaries. |
.github/hooks/subagent-validation/subagent-validation.sh |
Handles SDK responses and native advisories. |
.github/copilot-instructions.md |
Updates SDK contracts; critical: requiring complete-phase READY_VERIFIED blocks the default WORKER_EXECUTE/EXECUTE_VERIFIED path. |
.github/CODEOWNERS |
Assigns ownership to active skills. |
.github/agents/09-diagnose.agent.md |
Removes pins and adds SDK interaction rules. |
.github/agents/_subagents/terraform-validate-subagent.agent.md |
Removes pins and adds readiness rules. |
.github/agents/_subagents/terraform-plan-subagent.agent.md |
Removes pins and adds readiness rules. |
.github/agents/_subagents/policy-precheck-subagent.agent.md |
Removes pins and adds readiness rules. |
.github/agents/_subagents/cost-estimate-subagent.agent.md |
Removes pins and adds readiness rules. |
.github/agents/_subagents/challenger-review-subagent.agent.md |
Updates readiness and runtime-managed cache metadata. |
.github/agents/_subagents/bicep-whatif-subagent.agent.md |
Removes pins and adds readiness rules. |
.github/agents/_subagents/bicep-validate-subagent.agent.md |
Removes pins and adds readiness rules. |
.archive/pre-cpharness/tests/test_host_adapters.mjs |
Preserves historical adapter fixtures. |
.archive/pre-cpharness/skills/apex-host-workflow-start/SKILL.md |
Preserves the former workflow entry skill. |
.archive/pre-cpharness/skills/apex-host-git-commit/SKILL.md |
Preserves the former commit skill. |
.archive/pre-cpharness/skills/apex-host-debug-log-export/SKILL.md |
Preserves the former export skill. |
.archive/pre-cpharness/README.md |
Defines the archive’s non-runtime status. |
.archive/pre-cpharness/github-prompts/apex-resume-workflow.prompt.md |
Preserves the legacy resume adapter. |
.archive/pre-cpharness/github-prompts/apex-git-commit.prompt.md |
Preserves the legacy commit adapter. |
.archive/pre-cpharness/github-prompts/apex-debug-log-export.prompt.md |
Preserves the legacy export adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/10-challenger-review.prompt.md |
Preserves the Challenger adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/09-diagnose-resource.prompt.md |
Preserves the Diagnostics adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/08-as-built.prompt.md |
Preserves the As-Built adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/07t-terraform-deploy.prompt.md |
Preserves the Terraform deployment adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/07b-bicep-deploy.prompt.md |
Preserves the Bicep deployment adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/06t-terraform-codegen.prompt.md |
Preserves the Terraform generation adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/06b-bicep-codegen.prompt.md |
Preserves the Bicep generation adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/05-iac-planner.prompt.md |
Preserves the planning adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/04g-governance.prompt.md |
Preserves the governance adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/04-design.prompt.md |
Preserves the design adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/03-architect.prompt.md |
Preserves the architecture adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/02-requirements.prompt.md |
Preserves the requirements adapter. |
.archive/pre-cpharness/apex-prompts/workflow-prompts/00-resume-workflow.prompt.md |
Preserves the workflow resume adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/review-imported-iac.prompt.md |
Preserves the imported-IaC adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/project-wide-review.prompt.md |
Preserves the project-review adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/plan-fourLayerAgentAssessment.prompt.md |
Preserves assessment planning history. |
.archive/pre-cpharness/apex-prompts/utility-prompts/merge-sensei-free-pr.prompt.md |
Preserves the merge utility adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/execution-subagent.prompt.md |
Preserves the execution-contract adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/execution-subagent-gpt.prompt.md |
Preserves the GPT execution adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/context-audit.prompt.md |
Preserves the context-audit adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/assess-github-folder.prompt.md |
Preserves the folder-assessment adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/assess-agents.prompt.md |
Preserves the agent-assessment adapter. |
.archive/pre-cpharness/apex-prompts/utility-prompts/as-built-from-azure.prompt.md |
Preserves the Azure discovery adapter. |
Review effort: Balanced
Migration recovery assessmentThe earlier READY/all-complete report is withdrawn. Work continues on Verified facts
Invalid acceptance evidence
Preserve these records for diagnosis; do not restamp their hashes, reset review budgets, remove findings, Execution sequence
Autopilot boundaryAutopilot may perform scoped code changes, validation and technical handoffs without repeated permission prompts. |
…ance Resolve reviewer IDs from an explicit session and exact request ID. Reject post-dispatch metadata repair and unverified tool outcomes. Verify direct worker receipts without claiming continuation was tested. Restore strict telemetry checks and reopen unsupported completion claims. Validate source separately from incomplete workspace project artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Recovery commit 611a1f3 is pushed on the feature branch only. Source validation passed in an isolated candidate snapshot: validate:all (including Python suites), expanded Node regressions, hooks, governance-discovery tests, formatting, ESLint and Ruff. Shared-workspace validation remains non-green because project artifacts/state are not accepted; the earlier synthetic capture PASS and leading-review acceptance claims are withdrawn. See tools/plans/copilot-harness-migration/recovery-assessment.md. No merge, auto-merge or branch-protection bypass is authorized. The live test RG still exists; cleanup was denied by the tool guard. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix: remove executable reviewer draftsSource: The new owner-supplied cp-harness-01 transcript and its explicitly referenced native session establish:
The contract unnecessarily required hashing/serializing complete freeform findings inside executable commands. Validation: focused recorder/agent tests109 passed; tooling851 passed+2 skipped; source-only validate:all53 Node No project artifacts/state/findings were edited by this source repair. No review rerun, attempt reset, |
|
Post-push validation: source CI, external Python and secret-scan run39158595495 passed for98da7c46. Docs b780b7b verify/smoke also passed. Full source-only local validation passed before push. This does not validate the failed cp-harness-01 review, approve Gate1, reset attempts or authorize another review. No project state changes or Azure actions were performed by this repair. |
Align governance, artifact, shell and documentation guidance with actual contracts. Retire Local-only discovery settings and add pinned PowerShell analysis, hook integration and regression coverage. BREAKING CHANGE: remove fix:artifact-h2; use fix:artifacts with explicit --apply. Local-only customization location settings are no longer accepted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle negated Greenfield and coordinated migration or modernization terms. Add seven regressions and record the zero-credit deterministic validation pass. Preserve project artifacts, approvals and review-attempt history. Refs #772, #782, #786 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Unattended pass complete at source7487fe4a: all current PR checks passed, including source/external-Python CI, security/dependency checks and baseline/candidate amd64+arm64 container comparison. Companion jonathan-vella/apex-docs#43 at9c16f1d verify/smoke passed. Final staged source-only validate:all53 entries+external suites passed; focused128 and synthetic recovery/risk84 passed. Seven scenario-negation regressions were red before repair and green after. Total model-backed Copilot CLI sessions started:0, respecting the explicit zero-credit budget. Existing project/review/approval state remains untouched; production runtime acceptance is still open. |
Reject full JSON Schema roots and bound correction without re-asking captured answers. Record actual CLI evidence and preserve the prose-review recording blocker. Keep recorder integrity, review budgets, approvals and existing project artifacts unchanged. Refs #772, #773, #784, #786 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Delivered4b688a52 source and companion jonathan-vella/apex-docs#43 at325cf7b now have all checks passing, including source/external-Python/security and both baseline/candidate container architectures; docs verify/smoke passed. This does NOT close runtime acceptance: actual CLI rubber-duck returned prose and existing recorder correctly rejected it. No valid receipt or approval was created. Fresh same-prompt native-form retest passed after initial guidance repair; later payload/bound clarifications are source-tested. Exact actual sessions/usage and failed output remain outside checkout. No further model call or production review retry ran. |
|
Fresh PR feedback audit: fetched all review threads, reviews and general comments with pagination complete. All12 existing review threads are already resolved and have published disposition/fix replies; zero unresolved threads remain. The original Copilot overview saying6 open issues is historical text, not the current live thread state. No additional unaddressed actionable general-review feedback was found. Current source4b688a52 is committed/pushed and all19 checks pass. No new code or empty commit was needed. This audit does not waive the documented CLI prose-review recording blocker, supported-VS-Code acceptance gaps, or separate approval requirements. PR remains open with auto-merge disabled. |
Use the existing read-only typed leaf for automatic and optional manual review. Record actual native output with definition and procedure hashes; preserve historical readers. Align callers, skills, instructions, gate diagnostics and invocation accounting. Fresh CLI recording and strict validation pass; fresh VS Code context acceptance remains blocked. Refs #772, #773, #784, #786 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep execution-failure JSON out of findings and surface its exact stage and error. Preserve historical extraction and leave failed receipts unpublished. Refs #784 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Candidate8018a042 and docs82a0261b now have all PR checks passing, including source/external-Python/security/container comparisons and docs verify/smoke. The recommendation is implemented with one existing read-only typed leaf, parent recording, explicit failure-stage handling and preserved legacy readers. Related skill/instruction audit is complete. The fresh CLI produced a real receipt that passed strict validation against final source; refused replay preserved its bytes and the actual dispatch counts once. Native fresh-context acceptance is STILL BLOCKED: this running conversation used the old file-output role twice, including the owner-authorized post-refresh retry. Owner explicitly approved CLI-tested candidate publication; no result was relabelled, no counter/history reset and no production approval/Azure action/merge occurred. |
… repo - Align decision-keys.md complexity enum and register workflow toggles - Sync top-level iac_tool/region in apex-recall decide/transition/show - Validate multi-pass and simple-tier deep reviews in complete-step - Document subnet-plan and lesson-log enum constraints in instructions - Fix false negatives in decision-keys, lens-references, and context-budget - Fix in-progress step handling in validate-challenger-presence - Wire standalone contract validators and tests into validate:_node suites - Rebuild architecture-explorer-graph.json and eliminate skill lint warnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Full-repo workflow contract audit & validator remediation (
|
Fresh VS Code Session Acceptance Probe Passed (
|
Full End-to-End VS Code Production Acceptance Run Completed (
|
…ace validator - Forbid speculative view calls on unverified paths in reviewer (LL-001) - Document Storage restorePolicyDays < deleteRetentionPolicyDays rule (LL-002) - Accept not-applicable/auto-remediated rows in governance trace check (LL-003) - Emphasize kebab-case pricing_get args in cost-estimate-subagent (LL-004) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Applied
|
…ive migration plans - Incorporate PR #756 (.devcontainer/devcontainer-lock.json node feature 2.1.1). - Incorporate PR #765 devDependencies (eslint 10.12.0, eslint-plugin-n 18.4.1, js-yaml 5.4.3, jsdom 30.1.2, lefthook 2.2.1, prettier 3.9.10, whatwg-url 17.2.0) compatible with the 7-day Microsoft CFS packagefeedproxy.microsoft.io quarantine window. - Incorporate PR #766 (ruff 0.17.0 in requirements.txt) and configure a 7-day Dependabot cooldown for npm and pip ecosystems in .github/dependabot.yml. - Align tools/scripts/collect-governance-baseline.ps1 with discover.py parameter resolution, conditional effect evaluation, and PARTIAL discovery status reporting (#763). - Update README.md for challenger-review-subagent one-shot review recording and archive completed migration planning packets into .archive/post-cpharness-cleanup-20261019.tar.gz. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…idation suite - Fall back to governance-policy-baseline.fixture.json in validate-governance-baseline.mjs when the private compressed baseline has not yet been collected in a template clone. - Ignore upstream-only .github/workflows/* node paths in validate-explorer-graph.mjs when running in a downstream consumer repository without .github/workflows/ci.yml. - Guard upstream-only git history, workflow, and mermaid diagram assertions in audit-retirement-candidates.test.mjs, compare-devcontainer-verdicts.test.mjs, test_instruction_audit.mjs, and test_lint_commands.mjs so npm run validate:all passes cleanly in synced apex-accelerator repositories. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Complete Readiness Update (
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* docs: Document Copilot SDK harness cutover, rubber-duck reviews, and Autopilot - Update agent architecture and workflow guides for direct WORKER_EXECUTE and Autopilot - Document synchronous rubber-duck one-shot reviews and record-review.mjs - Add native SDK events.jsonl profiling and changelog entry for apex#779 Closes #40 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: qualify proposed SDK migration and restore anchors Restore published heading anchors, pin candidate migration sources, and separate proposed dispatch and export behavior from unverified runtime acceptance and human authority. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: align VS Code simplification proposal and approval gates Refs jonathan-vella/apex#779 and #40. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: align authorized migration and runtime hook retirement Distinguish execution authorization from unverified pilot and cloud boundaries. Retire runtime-hook setup guidance without disabling Git checks, and preserve published hook anchors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: align native agent bodies and task lifecycle Preserve direct main-agent questions, document native task returns and deliberate UI handoff removal, and separate source migration from runtime acceptance. Retain production review evidence and domain approval contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: clarify guided requirements and automatic review ownership Document the supplied Requirements discovery and sibling review candidate without claiming cp-harness01 runtime acceptance. Preserve approvals, review integrity, source pins, and published anchors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: explain direct review JSON and recording failure Record the observed sibling dispatch and blocked-command failure separately. Describe the shell-free source repair without approving a project retry. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: clarify negated Requirements scenarios Explain affirmative migration versus explicit negated scenario choices. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: record model-backed CLI findings and form limits Separate CLI observations from supported VS Code acceptance and preserve review blockers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: document shared structured reviewer candidate Adapt active review guidance to the owner-approved challenger-review-subagent JSON leaf, preserve historical failure evidence and unchanged approval gates, and keep final source and runtime claims pending. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: clarify structured reviewer payload types Document lenses for current manual batches and null or actual-finding arrays for deep-review prior_findings. Keep source and runtime candidate limits unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: distinguish CLI review success from blocked VS Code acceptance Record owner-supplied structured-leaf fixture success and the current VS Code old-role refusals without replacing historical failure evidence or claiming native acceptance. Clarify structured-only publication and read-only historical receipt compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: record reloaded VS Code acceptance and cp-harness-01 Azure E2E completion - Update agents, workflow, step-1, and changelog pages on docs/copilot-sdk-harness-cutover to record the completed October 19 reloaded VS Code Agent Host session (7735cb43-97f0-4d6e-9a31-8edd63dcc75b) and owner-authorized real-Azure cp-harness-01 end-to-end validation (Steps 1 -> 2 -> 3.5 -> 4 -> 5 -> 6 -> 7 -> Post-Lessons). - Document the five synchronous challenger-review-subagent receipts, strict record-review.mjs and --verify-cache validation, live Bicep deployment to rg-cp-harness-01-dev (32 resources in swedencentral), Step 7 as-built documentation (27.69/month, 0.00% drift), and LL-001..LL-004. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: incorporate PR #39 reopen cascade, step 2 check, and contract validator rules Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: incorporate PR #35 Azure MCP 3.0.0, azureterraform, and ALZ Corp baseline Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: incorporate PR #35 pricing_get updates and preserve #pricing-and-cost-tools anchor Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * chore: consolidate PRs #34-#38 and update source pins to merged apex@main - Incorporate Dependabot PRs #36 (astro-ecosystem), #37 (jsdom 30.1.2), and #38 (@playwright/test 1.64.0). - Update apex-source.json, docs-review.json, and public/architecture-explorer-graph.json (#34) to merged jonathan-vella/apex@main (d1cea2d1c04f9302827e683adafaeb079cd0b2b1) and jonathan-vella/apex-accelerator@main (b5c31fa5b07400cbb1379bf4447d6ecafdea6f57). - Preserve #azure-resource-manager-mcp-tools anchor in cost-governance.md for PR #35. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(deps): remove stale nested data-urls/node_modules/whatwg-url from package-lock.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Jonathan Vella <jonathan-vella@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>


Current delivery: native Copilot migration and instruction audit remediation
Current head:
51d596209bfefe808f6bc4a62bef111ae1afa3e7(previous head:03c1fa9918147ac1fbaf606fcf75b229adc41503).Latest delivery:
7735cb43-97f0-4d6e-9a31-8edd63dcc75b) acceptance and full real-Azurecp-harness-01E2E run (Steps 1 -> 2 -> 3.5 -> 4 -> 5 -> 6 -> 7 -> Post-Lessons, 32 resources inrg-cp-harness-01-dev, 5 structuredchallenger-review-subagentreceipts verified viarecord-review.mjs+--verify-cache).cp-harness-01lessons learned (LL-001–LL-004, commite480c7c1).#756,#765,#766) with 7-daypackagefeedproxy.microsoft.ioquarantine compatibility, alignedcollect-governance-baseline.ps1withdiscover.py(#763), archived migration packets into.archive/post-cpharness-cleanup-20261019.tar.gz(e0e46517), and added downstreamapex-acceleratorvalidation compatibility (51d59620).Full-repo workflow contract audit & validator remediation (
03c1fa99)tools/apex-recall/docs/decision-keys.mdcomplexityenum (simple | standard | complex) withworkflow-graph.jsonandvalidate-session-state.mjs, and registered workflow toggles (governance_depth,identity_resolution,diagnostics_strategy) and system keys (sku_overrides,challenger_skip,compliance,budget,architecture_pattern).iac_toolandregioninapex-recall decide,transition, andshow, and updatedcomplete-stepto validate multi-pass (pass1–pass3) andsimple-tierdeepreviews.subnet-plan.schema.jsonandlesson-log.schema.jsonenum constraints invnet-planning.md,lesson-collection.instructions.md,01-orchestrator.agent.md,02-requirements.agent.md, and03-architect.agent.md.validate-decision-keys.mjs,validate-lens-references.mjs,validate-context-budget.mjs,validate-challenger-presence.mjs,validate-iac-contract-consistency.mjs,validate-iac-handoff.mjs,validate-workflow-graph.mjs,validate-environment-manifest.mjs,validate-policy-property-map.mjs,validate-session-state.mjs,validate-no-hardcoded-counts.mjs,validate-orphaned-content.mjs, andtools/tests/workflow-handoffs/run.test.mjs.validate:_nodeandvalidate:_node-ci, eliminated all skill/orphaned-content lint warnings, and regeneratedtools/registry/architecture-explorer-graph.json(67/67 Node checks + 331/331 Pythonapex-recalltests passing).Shared structured reviewer candidate
10-Challengeruse the existingchallenger-review-subagent; no new reviewer or model pin was added.runs shell/code, asks questions or delegates. The parent captures inputs and records actual events.
that actual identity only; explicit JSON execution failures surface their real stage/error without publication.
Historical file-output schemas and
rubber-duckreceipts/extraction retain read-only compatibility.were audited and aligned: Azure defaults review/deep/gate references, workflow-engine execution/integration/
handoff/lifecycle references, agent-authoring guardrails and golden principles.
lenses, with the same recordedbatch_results; prior findings are null or compactactual-finding arrays, retaining IDs/severity/source paths. No duplicated manual file-output review mode remains.
and counts the real successful CLI dispatch as one Step 1 review. Existing attempts/caps are not reset.
7735cb43-97f0-4d6e-9a31-8edd63dcc75b)attached the updated
challenger-review-subagentdefinition and ran the bounded Step 1cp-harness-01requirements review probe (
request_id: cp-harness-01-requirements-review-1, worker05389820-d0af-4cee-a589-62331b976da3,tool call
call_MHxNZTd5UndiM0hLVEVxYlFJYmk, completed2026-10-19T11:27:38.449Z). It performed read-only file/searchinspection without writing files, returned raw typed JSON (
overall_assessment: "APPROVED",0 must_fix,0 should_fix,2 suggestion), and passed bothrecord-review.mjsatomic publication andvalidate-challenger-findings.mjs --verify-cachewith 0 errors. (Two earlier pre-reload probes in the previous VS Code window had returned the old file-output refusal.)
1a7ac903-df65-4910-ab0e-776f00b4051finvoked actual workerd25e954f-4c0e-47f7-82c7-9f8ccf6878a1.It returned typed JSON; actual-event recording and strict schema/provenance/freshness passed, also
against final current source. Refused replay preserved the receipt bytes. Its fixture verdict is not user approval.
validate:allpassed53 Node entries and external Python suites. Existing projects were excluded, not repaired or waived.
82a0261b937834dcde6de2301682cde853f9da95, with build/content/internal links and 13 tests passing.Current remote source/docs status is in the Checks tabs.
No merge, auto-merge, package/site publication or production approval occurred.
Earlier model-backed CLI findings, October 19
Earlier backend failure, preserved as history. The built-in CLI reviewer returned prose, so the unchanged
recorder rejected it. No valid review receipt or Gate 1 approval was created.
This is CLI evidence, not proof of the same behaviour in the supported VS Code harness.
four distinct root sessions and one independent native reviewer context.
Counting the resume and child conservatively gives six context launches.
Read-only tool projection and disabled MCP status were observed; no general credential-isolation
guarantee is inferred. Existing projects and credentials were not changed.
root
type/required. The existing native-form validator rejected it.Producer/parent guidance now requires only
requestedSchema.properties, keeps envelope metadataoutside direct tool calls and bounds schema correction without repeating settled answers.
Exact-session continuation also retained custom answers and returned guided workload questions.
REVIEW_REQUIRED. The parent dispatched exactly onesynchronous
rubber-duck; the actual request matched prepared scope and captured metadata.The response was preserved, not converted to findings, retried or approved. Recorder integrity,
review budgets and reviewer selection are unchanged.
33932850000in the emittedtotalNanoAiufield and 5 in the native legacy premium-request-cost field.Resumed and child usage is not counted twice. No USD or unverified credit conversion is claimed.
53 Node entries plus external Python passed. Docs build/content/internal links and 13 tests passed.
evidence directory outside the checkout. Current remote results are in the Checks tab.
changing production review architecture. No CLI-only adaptation expands product support.
Instruction audit remediation
required_valueand conditional mapping fields.The validator now rejects them; Copilot uses conventional or explicitly configured SDK discovery roots.
negative fixtures, package commands, development-container setup, CI and Git-hook integration.
fix:artifact-h2: usenpm run fix:artifacts -- <artifact-path>to preview,then add
--applyfor reviewed changes. Updated callers and migration documentation.Existing project/state/lock and project-infrastructure files remain outside the commit.
Earlier zero-credit unattended validation and repair
Copilot CLI 1.0.98 was identified through version/help; no model-backed CLI sessions or new reviewers ran.
npm run validate:all:53 Node validation entries, no failures, plus the external Python suites.
while coordinated negated migration/modernization labels triggered irrelevant questions.
The helper now strips the complete explicitly negated scenario list before branching.
discovery/recorder/Orchestrator suite passed 128 tests.
preserving captured answers and explicit unknowns without duplicate questions.
These are offline fixtures, not real reviewer or human-approval evidence.
compatibility tests also passed. No existing projects, reviews, attempt counters or credentials changed.
from deterministic tests, and no Azure operation or review retry was authorized by this pass.
Instruction-audit verification at a96c6a3
instruction checks, strict Explorer registry checks, changed-file formatting and Git-hook tests.
untracked project artifacts (structure, state, review provenance/presence, lesson schema,
SKU coverage and decision schemas). These were not rewritten or waived.
no runtime/protocol or rendering acceptance is inferred.
a96c6a31subsequently passed, including both container architecturesand the baseline/candidate verdict comparison. Earlier migration results below remain historical.
Official evidence: Copilot customization migration,
SDK discovery locations,
GitHub job semantics,
and PSScriptAnalyzer.
Delivered
This is tested-client evidence, not a universal platform claim.
00-handoff.mdremains recovery data.Native tasks use actual results and supported same-task handles; one-shot tasks are not universally resumable.
ask_user, including Requirements, Architect, Design and Governance.Direct selection can ask material questions; delegated mains return the form to their interactive parent.
durable state trust, destructive/change approval and ownership constraints.
Later correctness fixes are included in the current head; no token/cost/latency savings are claimed.
empty-inventory and literal-name failures. The initial remote failure was reproduced and regression-tested.
Requirements and automatic-review corrections
Native freeform values stay in the same field; there are no separate Other companions.
Existing company-size/workload answers are not asked again. Implementation contacts, principal IDs and runtime
bindings are deferred to the stage that consumes them, without relaxing security or later gates.
REVIEW_REQUIREDroutes the same independent nativerubber-duckthrough the authorized interactive parent as a sibling. Manual Challenger is not a routine detour.
cp-harness-01retry reached this reviewer dispatch, but a reviewer shell command wassafety-blocked. The recorder correctly rejected the interaction. No valid review sidecar or approval resulted.
the unchanged recorder derives IDs/counts and checks schema, attribution, original metadata and freshness.
Failed-command rejection remains intact. Requirements review is stage-aware and cannot invent approved
operational targets, authentication exceptions or automatic hard-cap spending enforcement.
Earlier migration validation (before instruction remediation)
npm run validate:allin an isolated exact source candidate: 53 Node validation entries pass,no failures, with external Python suites passing.
Guided-discovery/agent-policy tests: 65 passed; native rich-form Python tests: 30 passed.
baseline/candidate amd64/arm64 container builds and verdict comparison.
migration-only publication: generated project/state/lock and project-infrastructure files remain untracked,
untouched and outside this PR. No empty commit was created.
Runtime limits: do not call this full certification
Actual named Requirements/Architect/Design/Governance tasks returned delegated missing-input forms.
Validation/manual-review leaves returned declared missing-input failures without fabricated execution.
Earlier current-session what-if/Terraform-plan tasks returned bare
blocked, and cost demanded an obsoletehandshake despite updated source. The owner subsequently supplied fresh-session native-form transcripts for
all current user-facing main agents and role-specific missing-input failures for what-if/plan/cost,
without obsolete handshake requests. The bounded retests pass; older observations remain history.
This is owner-reported evidence, not a newly collected raw capture or proof of the earlier mismatch's cause.
The owner probe also showed Read/search with
tools: []; tool restrictions and credential isolationare not certified by source metadata. Cancellation/restart,
successful preview/pricing execution, genuine consequential approval and real-Azure E2E remain unverified.
Existing project/state validation failures and review freshness impacts are not waived or restamped.
Azure scope/budget/actions remain unprovided; no active account/default was substituted.
The latest retry establishes answer reuse during that resume and actual sibling review dispatch,
not a fresh guided-intake acceptance test or successful production recording.
The failed review attempt is preserved. No project review was rerun, no counter was reset, and
no historical hash, finding or approval was repaired by these source changes.
A further project review still requires explicit authorization within the existing allowance.
Delivery evidence
Companion documentation: jonathan-vella/apex-docs#43 at
82a0261b937834dcde6de2301682cde853f9da95.Current documentation verify/smoke results are in that PR's Checks tab.
Full migration/consequential/Azure acceptance remains BLOCKED where genuine evidence is missing.
Source body completion is not a roster-retirement claim, new approval or permission to merge.