Repository navigation
Log the outcome of scanning /samples on the SD card - #8
Merged
Merged
Conversation
A missing or unreadable /samples directory returned silently, so an empty library gave no hint in the boot log. Log that case and the WAV count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SampleLibrary::loadFromSdnow logs when/samplescannot be opened or is not a directory.Why
A missing or unreadable
/samplesreturned silently, so a library showing 0 samples gave no hint in the boot log. With these lines the log tells apart a mount failure (SD: mount failed), a missing directory, and an empty directory.Testing
Built with
make build-mainand flashed; boot log checked on the device.🤖 Generated with Claude Code