Skip to content

fix(android): keep callbacks on non-public base classes from R8 #8657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ItsChaceD wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −0
Open

fix(android): keep callbacks on non-public base classes from R8 #8657

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e472f1
fix(android): add R8 keep rules for callbacks and AGP 9
ItsChaceD Oct 14, 2026
921571d
chore(android): fix Android Studio warnings on the AGP 9 keep rules
ItsChaceD Oct 14, 2026
8d9c2b5
Merge branch 'main' into fix/RMET-5521/android-r8-core-rules-cap8
ItsChaceD Oct 15, 2026
80156e8
fix(android): remove Room and Firebase keep rules
ItsChaceD Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions android/capacitor/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
-keep @interface com.getcapacitor.annotation.** { *; }
-keep @interface com.getcapacitor.PluginMethod { *; }

# Callback methods are found by reflection, including on non-public base classes.
-keepclassmembers class * extends com.getcapacitor.Plugin {
@com.getcapacitor.annotation.ActivityCallback <methods>;
@com.getcapacitor.annotation.PermissionCallback <methods>;
}

# Rules for Capacitor v2 plugins and annotations
# These are deprecated but can still be used with Capacitor for now
-keep @com.getcapacitor.NativePlugin public class * {
Expand Down
Loading