Repository navigation
fix: Correct retry logic - #3703
Open
stevehipwell wants to merge 1 commit into
Open
stevehipwell wants to merge 1 commit into
stevehipwell wants to merge 1 commit into
Conversation
|
👋 Hi, and thank you for this contribution! This repo is maintained by GitHub and community members on a best-effort basis. We'll get to this as soon as we can. You can help us prioritize by joining the discussion on open issues and PRs, sharing details on the changes you need, and reviewing other contributions. 🤖 This is an automated message. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Retry preparation can interfere with the previous attempt’s request, and cancellation cleanup needs regression coverage.
2 open issues
What changed in this PR
These provider review instructions are being used.
This PR corrects request handling in the provider’s internal GitHub HTTP client retry transport.
Changes:
- Copies requests and restores request bodies before retrying.
- Cleans up retained responses when retries end with an error.
- Adds body-rewind tests and checks request payloads and attempt counts.
| File | Description |
|---|---|
internal/ghclient/retry.go |
Updates request copying, body replay, and response cleanup. |
internal/ghclient/retry_test.go |
Verifies retry counts and request payload preservation. |
internal/ghclient/body.go |
Adds a helper to restore request bodies using GetBody. |
internal/ghclient/body_test.go |
Tests body restoration and invalid request handling. |
Review effort: Balanced
stevehipwell
force-pushed
the
fix-retry-transport
branch
from
October 26, 2026 21:52
7e399c4 to
fb12af3
Compare
stevehipwell
force-pushed
the
fix-retry-transport
branch
from
October 26, 2026 22:09
fb12af3 to
ee900bc
Compare
Signed-off-by: Steve Hipwell <steve.hipwell@gmail.com>
stevehipwell
force-pushed
the
fix-retry-transport
branch
from
October 26, 2026 22:12
ee900bc to
9afae6a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolves #ISSUE_NUMBER
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!