Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{{ value[::0] }}currently silently renders an empty slice. Python/Jinja rejects this invalid step, even for empty lists and strings.Reject zero in the shared slice helper and cover empty/nonempty lists and strings through the public
Template.render()API. This is separate from the reverse-slice bounds fix in #2691.Validation: 768 tests pass across the templates, utilities, interpreter, formatting, and memory suites; Jinja build (including TypeScript declarations), ESLint, formatting, and
git diff --checkpass. The new zero-step regression fails before the change.The model-download e2e suite is excluded: this checkout lacks a built
@huggingface/hubworkspace dependency.Note
Low Risk
Narrow behavioral fix for invalid slice syntax with regression tests; no auth, data, or infrastructure impact.
Overview
Jinja slice behavior now matches Python for zero step: templates using
{{ value[::0] }}throw"slice step cannot be zero"instead of rendering an empty slice.The shared
slice()helper inutils.tsperforms the guard (consistent with existingrange()validation). New regression tests exercise empty/non-empty lists and strings throughTemplate.render().Reviewed by Cursor Bugbot for commit 622c470. Bugbot is set up for automated code reviews on this repo. Configure here.