Repository navigation
Stop faust2sc exports after C++ compiler failures - #1396
Closed
Ramji-Purwar wants to merge 1 commit into
Closed
Ramji-Purwar wants to merge 1 commit into
Ramji-Purwar wants to merge 1 commit into
Conversation
Check the scsynth and supernova compiler return statuses. A failed compilation now exits before copying class, help, or plugin files into the destination, instead of reporting a successful or partial export. Validation on the standalone fix: six script tests pass, including both failure subcases. Full CLI checks using a stub Faust generator and the real C++ compiler return exit code 1 for deliberate scsynth and supernova failures and leave the destination empty.
Member
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faust2sc.pyignored the return status of both C++ compiler invocations. It could exit successfully and copy class/help files into the destination even though the plugin failed to build, or only the scsynth variant succeeded.Check each return status and exit before publishing files when compilation fails. The error identifies whether scsynth or supernova failed.
Validation on this standalone branch:
python3 -m unittest discover -s tests/faust2sc-tests -v: six tests pass, including failure of each compiler invocation and stopping after the first failure.The CLI smoke tests use minimal generated C++ and temporary headers, rather than a complete SuperCollider build.