Skip to content

Stop faust2sc exports after C++ compiler failures - #1396

Closed
Ramji-Purwar wants to merge 1 commit into
grame-cncm:master-devfrom
Ramji-Purwar:fix/faust2sc-compiler-failures
Closed

Ramji-Purwar wants to merge 1 commit into
grame-cncm:master-devfrom
Ramji-Purwar:fix/faust2sc-compiler-failures

Conversation

@Ramji-Purwar

Copy link
Copy Markdown
Contributor

faust2sc.py ignored the return status of both C++ compiler invocations. It could exit successfully and copy class/help files into the destination even though the plugin failed to build, or only the scsynth variant succeeded.

Check each return status and exit before publishing files when compilation fails. The error identifies whether scsynth or supernova failed.

Validation on this standalone branch:

  • python3 -m unittest discover -s tests/faust2sc-tests -v: six tests pass, including failure of each compiler invocation and stopping after the first failure.
  • Complete CLI smoke tests with a stub Faust generator and the real GCC 16.2.1 C++ compiler: deliberate scsynth and supernova errors each return exit code 1 and leave the destination empty. The original script incorrectly returns success after a compiler error.

The CLI smoke tests use minimal generated C++ and temporary headers, rather than a complete SuperCollider build.

Check the scsynth and supernova compiler return statuses. A failed compilation now exits before copying class, help, or plugin files into the destination, instead of reporting a successful or partial export.

Validation on the standalone fix: six script tests pass, including both failure subcases. Full CLI checks using a stub Faust generator and the real C++ compiler return exit code 1 for deliberate scsynth and supernova failures and leave the destination empty.
@sletz

sletz commented Nov 16, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@sletz sletz closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants