Skip to content

Fix faust2sc compilation paths containing spaces - #1395

Closed
Ramji-Purwar wants to merge 1 commit into
grame-cncm:master-devfrom
Ramji-Purwar:fix/faust2sc-quoted-paths
Closed

Ramji-Purwar wants to merge 1 commit into
grame-cncm:master-devfrom
Ramji-Purwar:fix/faust2sc-quoted-paths

Conversation

@Ramji-Purwar

Copy link
Copy Markdown
Contributor

Addresses #752.

faust2sc.py already preserves paths in the initial Faust invocation, but its subsequent C++ commands interpolate include, source, and output paths without shell quoting. Spaces split arguments and apostrophes can break the command entirely.

Quote those paths for the existing shell commands and remove only the line ending from faust -includedir. Compiler wrappers such as CXX="ccache c++" remain supported.

Validation on Linux x86_64 with GCC 16.2.1:

  • python3 -m unittest discover -s tests/faust2sc-tests -v: seven tests pass; both new path regressions fail without the fix.
  • Compiled and loaded minimal scsynth/supernova shared-library variants using paths containing spaces and apostrophes, verifying all five include directories. The smoke test uses temporary headers and a stub faust -includedir response.

A complete SuperCollider plugin build and macOS execution were not run.

Quote include, source, and output paths when constructing scsynth and supernova compiler commands. Remove only the includedir line ending so a path remains one argument, including apostrophes and trailing spaces. Preserve CXX wrappers and flags.

Addresses grame-cncm#752. Verified with seven script tests and real shared-library builds and loads through paths containing spaces and apostrophes.
@sletz

sletz commented Nov 16, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@sletz sletz closed this Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants