Repository navigation
Fix faust2sc compilation paths containing spaces - #1395
Closed
Ramji-Purwar wants to merge 1 commit into
Closed
Ramji-Purwar wants to merge 1 commit into
Ramji-Purwar wants to merge 1 commit into
Conversation
Quote include, source, and output paths when constructing scsynth and supernova compiler commands. Remove only the includedir line ending so a path remains one argument, including apostrophes and trailing spaces. Preserve CXX wrappers and flags. Addresses grame-cncm#752. Verified with seven script tests and real shared-library builds and loads through paths containing spaces and apostrophes.
Member
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #752.
faust2sc.pyalready preserves paths in the initial Faust invocation, but its subsequent C++ commands interpolate include, source, and output paths without shell quoting. Spaces split arguments and apostrophes can break the command entirely.Quote those paths for the existing shell commands and remove only the line ending from
faust -includedir. Compiler wrappers such asCXX="ccache c++"remain supported.Validation on Linux x86_64 with GCC 16.2.1:
python3 -m unittest discover -s tests/faust2sc-tests -v: seven tests pass; both new path regressions fail without the fix.faust -includedirresponse.A complete SuperCollider plugin build and macOS execution were not run.