Repository navigation
Make rotate a no-op on an empty range. - #8783
Merged
Merged
Conversation
`rotate(array, distance, fromIndex, toIndex)` computed `length` and `-distance % length` without guarding an empty range, so a call with `fromIndex == toIndex` threw `ArithmeticException`. Return early when the range has fewer than two elements. Fixes #8772 Fixes #8774 RELNOTES=`primitives`: Fixed `ArithmeticException` when calling `rotate` on an empty subrange of a multi-element array. PiperOrigin-RevId: 1006325060
copybara-service
Bot
force-pushed
the
test_1004859613
branch
from
October 24, 2026 16:23
e8d957c to
5ae56d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
rotatea no-op on an empty range.rotate(array, distance, fromIndex, toIndex)computedlengthand-distance % lengthwithout guarding an empty range, so a call withfromIndex == toIndexthrewArithmeticException. Return early when the range has fewer than two elements.Fixes #8772
Fixes #8774
RELNOTES=
primitives: FixedArithmeticExceptionwhen callingrotateon an empty subrange of a multi-element array.