Skip to content

fix(xml): prevent XXE in xml.xpath (disable DTD + external entities) #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogikortisa wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

fix(xml): prevent XXE in xml.xpath (disable DTD + external entities) #357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions java/com/google/copybara/xml/XmlModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ public Object compile(String xmlContent, String expression, String type)
DocumentBuilderFactory builderFactory = DocumentBuilderFactory.newInstance();
DocumentBuilder builder;
try {
// Prevent XML External Entity (XXE) processing: reject DTDs (which also
// disables entity resolution) and external entities, since the parsed XML
// content may come from an untrusted source (e.g. a migrated repository).
builderFactory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
builderFactory.setXIncludeAware(false);
builderFactory.setExpandEntityReferences(false);
builder = builderFactory.newDocumentBuilder();
} catch (ParserConfigurationException e) {
throw new RuntimeException("Error creating document builder for parsing XML");
Expand Down
Loading