Repository navigation
Conversation
LiteralNode.String trimmed all trailing newlines from Origin, so "|+" lost blank lines on AST round-trip. Keep them for keep chomping, avoid double-counting when joining mapping entries, and credit those blanks in checkLineBreak. Fixes goccy#826.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #969 +/- ##
=======================================
Coverage 80.65% 80.65%
=======================================
Files 22 22
Lines 6845 6845
=======================================
Hits 5521 5521
Misses 905 905
Partials 419 419 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #826.
LiteralNode.String()always ranTrimRight(..., "\n")on the scalar Origin. For|/|-that is fine. For|+ keep chomping it dropped the trailing blank lines, soparser.ParsethenFile.String()lost them and a decode of the rewritten YAML no longer matched.Changes:
|+ or>+.checkLineBreak, count those keep-chomped trailing blanks on the previous string token so the next key does not emit them a second time.Test plan:
TestKeepBlockScalarTrailingBlanksround-trips the issue reproducer through ASTString()and checks the decoded message is unchanged.go test ./...passes locally.