Skip to content

fix(host): close a client socket at its backpressure limit instead of dropping frames #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 2 commits into from
Oct 15, 2026
Merged

fix(host): close a client socket at its backpressure limit instead of dropping frames #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03b1541
fix(host): close a client socket at its backpressure limit instead of…
iamnbutler Oct 15, 2026
666a667
lane: sync stale-run memory
iamnbutler Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .../host/src/gateway.ts/01M50KBA3ME0Q9274A639MK6KJ-gateway-sockets-must-never-d.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
id: 01M50KBA3ME0Q9274A639MK6KJ
anchor: function websocket
created: 2026-10-15T20:16:37Z
norm: '1'
sig: 1b462e5d3bc33728
body_hash: aee7bf28626367fb
raw_hash: 6675f75b614405d9
lines: 673-737
---

gateway sockets must never drop a frame silently; past the backpressure limit they close so the client reconnects and re-watches
5 changes: 5 additions & 0 deletions apps/host/src/gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,6 +672,11 @@ async function handle(

function websocket(): Bun.WebSocketHandler<Client> {
return {
// Past the limit Bun drops frames silently, and a watch that loses one, such as a run's end,
// stays wrong; closing makes the client reconnect and re-watch. Screenshot-heavy chats replay
// tens of megabytes to a renderer that reads slowly while it draws them.
backpressureLimit: 128 * 1024 * 1024,
closeOnBackpressureLimit: true,
open(socket) {
sockets.add(socket);
log("info", "gateway.open", { user: socket.data.user, peer: socket.data.peer });
Expand Down