Repository navigation
chore: remove leftover env overrides, exports, and script aliases - #436
Merged
Merged
Conversation
Drops ACE_WORKER, ACE_APP_DIR and VITE_ACE_HOST, which nothing sets; @ace/host's unused bin and '.', './gateway' and './keys' exports; services/channel's unused chord dependency; and the desktop's uncalled stage alias.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes leftovers found while auditing the CLI and scripts. Every item has no caller on main:
ACE_WORKERandACE_APP_DIR(apps/host/src/config.ts). Nothing sets them, and the Helper setsconfig.workerandconfig.appdirectly.VITE_ACE_HOST(apps/app/src/address.ts,env.d.ts). Nothing sets it, and the Vite dev proxy already serves/ws.@ace/hostpackage entries: thebinand the.,./gatewayand./keysexports. Nothing imports them, and the rootacescript runscli.tsby path.@earendil-works/chordinservices/channel. Nothing there imports it.stagealias.build.tsrunsscripts/stage.tsdirectly.bun typesandbun run cipass, andbun ace --helpruns.Built in Ace
No. This was built with Claude Code outside Ace, because this Mac's Ace Canary was a member of the two-person study and couldn't be used for development. Dogfooding gap: #5.