Skip to content

fix(app): skip the composer's model lookup while a channel is offline #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamnbutler merged 1 commit into from
Oct 15, 2026
Merged

fix(app): skip the composer's model lookup while a channel is offline #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions apps/app/src/composer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,10 @@ export function Composer(
composer.current?.set(ACE.test(draft) ? draft : `@ace ${draft}`);
onDraftLoaded();
}, [draft, onDraftLoaded]);
// An offline channel can't answer; the conversation already says so, so don't blame providers.
const offline = channel.state === "offline";
useEffect(() => {
if (status !== "open" || mode !== "ace") return;
if (status !== "open" || mode !== "ace" || offline) return;
let active = true;
// Ask the channel itself: a hosted channel uses the service's credentials, not its workspace's.
host.channel<ModelOption[]>(channel.id, { op: "models" }).then(
Expand All @@ -147,7 +149,7 @@ export function Composer(
return () => {
active = false;
};
}, [channel.id, mode, status, settingsVersion]);
}, [channel.id, mode, status, settingsVersion, offline]);
const [{ model: picked, effort: pickedEffort }, changePick] = useLocalStorage(
`ace:pick:${scope}/${id}`,
UNPICKED,
Expand Down Expand Up @@ -268,7 +270,7 @@ export function Composer(
/>
{refused
? <Refusal mode={mode} onChat={toChat} />
: mode === "ace" && models?.length === 0 && (
: mode === "ace" && !offline && models?.length === 0 && (
<Notice
action={onSettings && (
<Button size="sm" variant="ghost" onClick={onSettings}>Provider settings</Button>
Expand Down