Repository navigation
fix(desktop): focus editable fields at click points - #141
Merged
Merged
Conversation
…nate-check # Conflicts: # apps/desktop/native/patches/README.md # apps/desktop/scripts/helper.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix coordinate clicks on editable Accessibility fields so they use the same verified keyboard-focus path as element clicks. A point click on Ace's own composer previously returned unknown and left it unfocused. The raw hit test now runs on the existing bounded read lane, and process generation, exact window bounds, and element ownership are rechecked immediately before mutation. Positional AXPress retains native ownership until its actual return; no retry or post-dispatch fallback is added.
Related: githubnext/ace2#8, githubnext/desktop-tools#5. This proves the composer case; other githubnext/desktop-tools#5 cases remain open. Keyboard focus does not promise click-to-character caret positioning.
Validation at
75f20cc:bun types,bun run ci, GitHub CI, ordered patch checks, Swift compilation, and the signed desktop build pass. Strict app/client/library/launcher signatures and independent source review pass.unknown, leaving the publicacedraft unchanged and unfocused. After the fix, one point click returnedcompletedwith nativeconfirmed_change, backgroundaccessibility_valuedelivery, and exactly one unit. Fresh inspection confirmed focus, the same draft, and collapsed caret offset 4.Built in Ace
Used Codex's direct filesystem, terminal, and review tools under the user's explicit exception to finish githubnext/ace2#8 faster. The regression is Ace controlling its own composer (#106), which prevented relying on Ace's computer-use flow for this fix. Validation used Ace's signed desktop bridge and a disposable Ace channel. See #5 and githubnext/ace2#8.