Repository navigation
fix(app): stream the reply draft inside the timeline instead of over it - #114
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The streaming reply was rendered as an absolutely positioned, unstyled overlay pinned to the bottom of the chat. Long drafts covered the transcript as raw markdown. The draft now joins the timeline as a streaming agent message, labeled with the chat's model, so it is laid out, formatted, and scrolled like other messages, and the final reply replaces it.
Smoke-tested against a separate
ace serveand Vite with a long Opus reply: mid-stream, the draft rendered inside the agent message, pinned to the bottom with no overlap, and the final message replaced it cleanly.Built in Ace
The code, checks, and commit were done in Ace. For the visual smoke test: