Repository navigation
Harden Copilot CLI and Cloud Hypervisor compatibility #69162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
d330bd7
ee8d4f9
9fe4657
c244341
26a6d4f
1fc08e9
c9cae91
c29fcdd
d22a541
fc2ae57
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -148,7 +148,7 @@ func (e *CopilotEngine) GetInstallationSteps(workflowData *WorkflowData) []GitHu | |
| // the rootless location to ${RUNNER_TEMP}/gh-aw/bin/copilot where AWF expects it. | ||
| rootless := isArcDindTopology(workflowData) | ||
| compiledVersion := workflowData.CompiledVersion | ||
| npmSteps := generateCopilotInstallerSteps(copilotVersion, "Install GitHub Copilot CLI", rootless, compiledVersion, "", getNVXGuestLibc(workflowData)) | ||
| npmSteps := generateCopilotInstallerSteps(copilotVersion, "Install GitHub Copilot CLI", rootless, compiledVersion, string(constants.CopilotSessionIDMinVersion), getNVXGuestLibc(workflowData)) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Covered in |
||
| if len(inlineDriverWriteStep) > 0 { | ||
| npmSteps = append(npmSteps, inlineDriverWriteStep) | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Covered in
c2443410: the test includesconstants.AwInfoPath, checks it is absent only from the mkdir script, and confirms it remains in the generated AWF configuration. Confirmed again after mergingmainin1fc08e9.