Repository navigation
Add JVM Pulse to the external canvas extension catalog - #5086
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8e62e475-4d1b-47f2-a0a4-744ca71279dc
🚦 Submission status: 👀 Ready for reviewRisk tier: Why this tier
Automated checks
Review
Commands
Updated for |
|
🟡 Contributor Reputation Check: MEDIUM risk
Maintainers: please review this contributor before merging. |
There was a problem hiding this comment.
🟢 Approval recommended
The entry matches the supported plain-repository canvas catalog path and verified upstream metadata.
0 open findings
What changed in this PR
Registers JVM Pulse in the website’s external canvas catalog without vendoring code or adding a marketplace plugin.
Changes:
- Adds profiling metadata, tags, author information, and JDK requirements.
- Links the upstream repository and a commit-pinned dashboard screenshot.
| File | Description |
|---|---|
extensions/external.json |
Adds JVM Pulse’s catalog metadata and upstream links. |
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aaronpowell
left a comment
There was a problem hiding this comment.
Thanks, this is a clean catalog-only registration. The JDK 17/JDK 21 requirements match the upstream README, the preview is commit-pinned, and the entry uses the supported repository install path rather than a fabricated marketplace link. All automated content checks pass; the gate is waiting for approval. LGTM.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Register JVM Pulse in
extensions/external.jsonusing the existing external canvas catalog mechanism. JVM Pulse profiles Java workloads or analyzes existing GC logs with Microsoft GCToolkit and optional JFR recordings with the JDKjfrCLI. Its canvas shows throughput, pauses, heap, allocations, and hot methods, with run history, comparisons, and Copilot-assisted tuning advice.The entry links to the public repository for installation and source, uses its version and author metadata, and pins the dashboard screenshot to published commit
4553e655bf8c31cfd2eaf6c50c9c7e3269944638. It states the analysis requirements: JDK 17+, with JDK 21+ for full JFR views. Installation directions are in the upstream README.This is a catalog-only contribution: no implementation is vendored, and no skills or plugins are added. The source repository is MIT-licensed, and I am its author. No existing JVM Pulse catalog entry or PR was found.
Type of Contribution
Additional Notes
Only
extensions/external.jsonchanges. Generated README and marketplace files remain unchanged; external canvas entries are consumed by website data generation, andwebsite/public/data/is ignored by Git.Validation in this contribution workspace:
npm run plugin:validatenpm start(runsnpm run build)npm run website:datanpm run --prefix website build/extension/jvm-pulse/generated successfully.node --test eng/extension-plugin-ownership.test.mjsbash eng/fix-line-endings.shgit diff --checkimage/png.The source publication session separately confirmed
node --check extension.mjspassed andnode --test test/*.test.mjspassed 43/43 tests, including local JVM and Docker attach coverage, with a clean source workspace at the published commit. No fresh interactive Copilot profiling capture was performed for this catalog-only change; the runtime-testing checkbox is intentionally left unchecked. The new-file checkbox is also intentionally unchecked because this contribution adds a catalog entry rather than an in-repository implementation file.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.