Skip to content

Route workshop changes to workshop reviewers - #4743

Merged
aaronpowell merged 2 commits into
mainfrom
codeowner-cleanup
Oct 9, 2026
Merged

aaronpowell merged 2 commits into
mainfrom
codeowner-cleanup

Conversation

@aaronpowell

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have read and followed the Guidance for submissions involving paid services.
  • My contribution adds a new instruction, prompt, agent, skill, workflow, or canvas extension file in the correct directory.
  • The file follows the required naming convention.
  • The content is clearly structured and follows the example format.
  • I have tested my instructions, prompt, agent, skill, workflow, or canvas extension with GitHub Copilot.
  • I have run npm start and verified that README.md is up to date.
  • I am targeting the main branch for this pull request.

Description

Routes changes to the Copilot workshop Learning Hub trees to the new @github/awesome-copilot-workshop-reviewers team.

This updates CODEOWNERS, adds a dedicated workshops intent label and reviewer pool, maps workshop paths to that pool for submission-gate ownership, and updates the maintainer documentation. The repository workshops label has also been created.

Validation:

  • bash eng/fix-line-endings.sh — passed; Markdown files normalized to LF.
  • git diff --check — passed.
  • node eng/review-routing.mjs validate — passed; all routing pools and routes are valid.
  • node --test eng/review-routing.test.mjs eng/submission-gate.test.mjs — passed; 92 tests passed, 0 failed.
  • npm start — not run because this change does not add catalog resources or affect generated README/marketplace output.

Type of Contribution

  • New instruction file.
  • New prompt file.
  • New agent file.
  • New plugin.
  • New skill file.
  • New agentic workflow.
  • New canvas extension.
  • Update to existing instruction, prompt, agent, plugin, skill, workflow, or canvas extension.
  • Other (please specify): CODEOWNERS, review routing, approval policy, and maintainer documentation update.

Additional Notes

The review router remains in its existing global dry_run: true state. The workshop pool has no individual reviewers configured yet, so when routing is enabled it falls back to requesting the workshop team.


By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.

aaronpowell and others added 2 commits October 9, 2026 11:21
Removed a lot of excessive codeowners
Created a new team for reviewing/approving workshops
Removed workflow that did auto-assignment
Add workshop ownership, intent labeling, reviewer routing, approval-domain coverage, and maintainer documentation for the new workshop review team.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aaronpowell
aaronpowell requested a review from a team as a code owner October 9, 2026 00:29
Copilot AI balanced review requested due to automatic review settings October 9, 2026 00:29
@github-actions

github-actions Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

🚦 Submission status: 👀 Ready for review

Risk tier: merge-risk:high — Privileged execution, automation, or review-policy change
Required to merge: passing submission-gate checks plus 2 approvals from reviewers with write access, including a maintainer with admin or maintain permission.

Why this tier
  • .github/review-routing.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/risk-tiers.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/workflows/codeowner-update.lock.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/workflows/codeowner-update.md is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/workflows/label-pr-intent-writer.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/workflows/label-pr-intent.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • .github/workflows/setup-labels.yml is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • CODEOWNERS is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/review-routing.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/review-routing.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)
  • eng/submission-gate.test.mjs is a high-risk path (automation, scripts, MCP config, hooks, or review policy)

Automated checks

Check Status Details
Line endings ✅ Passed Passed · logs
Spelling ✅ Passed Passed · logs
Generated README consistency ✅ Passed Passed · logs
Submission gate tests ✅ Passed Passed · logs
Contributor reputation ✅ Passed Passed · logs
Duplicate resource scan ⏳ Pending (advisory, non-blocking) Running · logs
PR quality signal ⏳ Pending (advisory, non-blocking) Running · logs

Review

  • Approvals: 0/2
  • Assigned reviewer: not assigned yet — comment /request-review to ask for one
  • Review target date: not set
  • Still needed: 2 more approval(s); an approval from a maintainer with admin or maintain permission
  • The core-maintainers pool is not staffed yet; an approver with admin or maintain permission is required instead.

Commands

Command Who What it does
/rerun-checks PR author, maintainers Re-runs failed or incomplete checks and re-evaluates this gate
/request-review PR author, maintainers Asks the review rotation to assign a reviewer (adds needs-reviewer)

Updated for d7f504c · gate run · This comment is maintained automatically — see submission gate docs.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🟡 Contributor Reputation Check: MEDIUM risk

Check Risk
Profile MEDIUM
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk ready-for-review Submission passed intake validation and is ready for maintainer review and removed awaiting-automation labels Oct 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Workshop asset paths and automated sync PRs can bypass the new workshop routing and ownership rules.

4 open findings
What changed in this PR

Routes Learning Hub workshop changes to a dedicated reviewer team and approval domain.

Changes:

  • Adds workshop intent labeling, routing, ownership, and tests.
  • Moves CODEOWNERS to team-based ownership.
  • Removes the legacy #codeowner workflow.
File Description
CODEOWNERS Assigns workshop paths to the workshop team.
.github/​review-routing.yml Adds the workshop reviewer pool and route.
.github/​risk-tiers.yml Adds the workshop approval domain.
.github/​workflows/​label-pr-intent.yml Detects workshop changes.
.github/​workflows/​label-pr-intent-writer.yml Manages the workshop label.
.github/​workflows/​setup-labels.yml Defines the workshop label.
.github/​workflows/​codeowner-update.md Removes legacy ownership automation.
.github/​workflows/​codeowner-update.lock.yml Removes its compiled workflow.
eng/​review-routing.mjs Registers the workshop intent label.
eng/​review-routing.test.mjs Tests workshop routing priority.
eng/​submission-gate.test.mjs Tests workshop reviewer approval.
docs/​maintainers/​review-routing.md Documents the revised ownership model.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/risk-tiers.yml
Comment on lines +147 to +150
paths:
- "website/**/cli-for-beginners/**"
- "website/**/app-for-beginners/**"
- "website/**/copilot-workshops/**"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix the code for all comments in this review comment.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review comment.

Comment on lines +82 to +84
workshops: [
/^website\/(?:.*\/)?(?:cli-for-beginners|app-for-beginners|copilot-workshops)\//
],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix the code for all comments in this review comment.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review comment.

Comment on lines +137 to +139
if (filenames.some((filename) => matchesAny(filename, patterns.workshops))) {
desiredLabels.add('workshops');
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix the code for all comments in this review comment.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review comment.

Comment thread CODEOWNERS
Comment on lines +24 to +25
/website/**/cli-for-beginners/ @github/awesome-copilot-workshop-reviewers
/website/**/app-for-beginners/ @github/awesome-copilot-workshop-reviewers

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fix the code for all comments in this review comment.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review comment.

@aaronpowell
aaronpowell merged commit c06f74a into main Oct 9, 2026
33 of 35 checks passed
@aaronpowell
aaronpowell deleted the codeowner-cleanup branch October 9, 2026 00:34
@suckyourmomonoktagon

Copy link
Copy Markdown

@copilot Fix the code for all comments in this review thread.

When a review comment includes a suggested change, apply the suggestion exactly.

Do not make changes beyond what is described in the linked review thread.

This branch was successfully deployed

1 active deployment
github-pages — d7f504c5 Deployed Oct 9, 2026 by aaronpowell via deploy #727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk:high needs-review:MEDIUM Contributor reputation check flagged MEDIUM risk ready-for-review Submission passed intake validation and is ready for maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants